openstack
/
designate
Code Issues Proposed changes

Fix designate-manage pool update MissingProjectID 

This patch fixes a bug where adding an additional pool to designate using the "designate-manage pool update" command may fail with an exception:

designate.exceptions.MissingProjectID: A project ID must be specified when not using a project scoped token.

There was an extra check added as part of the scoped token work that a project ID must be provided when creating pools. This was incorrect as pools are still valid with a None project ID as they are a system resource and not tied to a specific project.

This patch removes that check, but retains the RBAC check for and "admin" token.

Closes-Bug: #1986733
Change-Id: I7345d7ef505420767209ba037e3c8930a282d03f
This commit is contained in:
Michael Johnson 2022-08-16 22:17:39 +00:00
parent 927e34ee5a
commit a03c4657c2
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
designate/central/service.py
View File

@ -1980,8 +1980,6 @@ class Service(service.RPCService):
policy.check('create_pool', context)
self._is_valid_project_id(pool.tenant_id)
created_pool = self.storage.create_pool(context, pool)
return created_pool

6
releasenotes/notes/fix-designate-manage-pool-7d812f938e894133.yaml Normal file
View File

@ -0,0 +1,6 @@
---
fixes:
- |
Fixed an issue in central where "designate manage pool update" may return
an error designate.exceptions.MissingProjectID when attempting to create a
new pool.