openstack/designate
Code Issues Proposed changes

Add better get_ip_address coverage

Browse Source 
Change-Id: I93be8d34dc38eb6e63b4d32b180df01ad61d2385
This commit is contained in:
Erik Olof Gunnar Andersson 2023-11-17 13:10:48 -08:00
parent 8805a02bed
commit ac8fc0a826
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
designate/tests/unit/test_dnsutils.py
View File

@ -39,6 +39,18 @@ class TestDNSUtils(oslotest.base.BaseTestCase):
super().setUp() super().setUp()
self.useFixture(cfg_fixture.Config(CONF)) self.useFixture(cfg_fixture.Config(CONF))
@mock.patch('socket.getaddrinfo')
def test_get_ip_address(self, mock_getaddrinfo):
mock_getaddrinfo.return_value = [
(socket.AF_INET, socket.SOCK_STREAM, 0, '', ('192.0.2.1', 0))
]
self.assertEqual('192.0.2.1', dnsutils.get_ip_address('test'))
@mock.patch('socket.getaddrinfo')
def test_get_ip_address_none(self, mock_getaddrinfo):
mock_getaddrinfo.return_value = []
self.assertIsNone(dnsutils.get_ip_address('test'))
@mock.patch.object(dns.query, 'udp') @mock.patch.object(dns.query, 'udp')
def test_send_udp_dns_message(self, mock_udp): def test_send_udp_dns_message(self, mock_udp):
CONF.set_override('all_tcp', False, 'service:worker') CONF.set_override('all_tcp', False, 'service:worker')