Remove Hacking check for log translation
Change-Id: I9ab9215e58f6b94029649b8b5cec69ef13b0b6ac
This commit is contained in:
parent
44fa7d7d1c
commit
e147cc82eb
|
@ -34,8 +34,6 @@ UNDERSCORE_IMPORT_FILES = []
|
||||||
mutable_default_argument_check = re.compile(
|
mutable_default_argument_check = re.compile(
|
||||||
r"^\s*def .+\((.+=\{\}|.+=\[\])")
|
r"^\s*def .+\((.+=\{\}|.+=\[\])")
|
||||||
string_translation = re.compile(r"[^_]*_\(\s*('|\")")
|
string_translation = re.compile(r"[^_]*_\(\s*('|\")")
|
||||||
log_translation = re.compile(
|
|
||||||
r"(.)*LOG\.(audit|error|info|warn|warning|critical|exception)\(\s*('|\")")
|
|
||||||
translated_log = re.compile(
|
translated_log = re.compile(
|
||||||
r"(.)*LOG\.(audit|error|info|warn|warning|critical|exception)"
|
r"(.)*LOG\.(audit|error|info|warn|warning|critical|exception)"
|
||||||
"\(\s*_\(\s*('|\")")
|
"\(\s*_\(\s*('|\")")
|
||||||
|
@ -56,17 +54,6 @@ def mutable_default_arguments(logical_line, physical_line, filename):
|
||||||
yield (0, "D701: Default parameter value is a mutable type")
|
yield (0, "D701: Default parameter value is a mutable type")
|
||||||
|
|
||||||
|
|
||||||
def validate_log_translations(logical_line, physical_line, filename):
|
|
||||||
# Translations are not required in the test directory
|
|
||||||
if "designate/tests" in filename:
|
|
||||||
return
|
|
||||||
if pep8.noqa(physical_line):
|
|
||||||
return
|
|
||||||
msg = "D702: Log messages require translation"
|
|
||||||
if log_translation.match(logical_line):
|
|
||||||
yield (0, msg)
|
|
||||||
|
|
||||||
|
|
||||||
def no_translate_debug_logs(logical_line, filename):
|
def no_translate_debug_logs(logical_line, filename):
|
||||||
"""Check for 'LOG.debug(_('
|
"""Check for 'LOG.debug(_('
|
||||||
As per our translation policy,
|
As per our translation policy,
|
||||||
|
@ -160,7 +147,6 @@ def check_no_log_audit(logical_line):
|
||||||
|
|
||||||
def factory(register):
|
def factory(register):
|
||||||
register(mutable_default_arguments)
|
register(mutable_default_arguments)
|
||||||
register(validate_log_translations)
|
|
||||||
register(no_translate_debug_logs)
|
register(no_translate_debug_logs)
|
||||||
register(check_explicit_underscore_import)
|
register(check_explicit_underscore_import)
|
||||||
register(no_import_graduated_oslo_libraries)
|
register(no_import_graduated_oslo_libraries)
|
||||||
|
|
Loading…
Reference in New Issue