openstack/designate
Code Issues Proposed changes

Replace assertEqual(None, *) with assertIsNone in tests

Browse Source 
Replace assertEqual(None, *) with assertIsNone in tests to have more
clear messages in case of failure.

Change-Id: I471f34681f1bac78b9a6b4fe2e39f79670f5f25c
Closes-Bug:#1280522
This commit is contained in:
vishal mahajan 2016-01-18 18:44:11 +05:30
parent 62f578174b
commit e45a5b10aa
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
functionaltests/api/v2/test_zone_ownership_transfers.py
View File

@ -59,7 +59,7 @@ class TransferZoneOwnerShipTest(DesignateV2Test):
# self.assertEqual(self.zone.name, fixture.transfer_request.zone_name)
self.assertEqual(TransferRequestClient.as_user(fixture.user).tenant_id,
fixture.transfer_request.project_id)
self.assertEqual(fixture.transfer_request.target_project_id, None)
self.assertIsNone(fixture.transfer_request.target_project_id)
# check that the zone_name is filled in
resp, transfer_request = TransferRequestClient.as_user(fixture.user) \
@ -76,7 +76,7 @@ class TransferZoneOwnerShipTest(DesignateV2Test):
.get_transfer_request(fixture.transfer_request.id)
self.assertEqual(resp.status, 200)
self.assertEqual(getattr(transfer_request, 'key', None), None)
self.assertIsNone(getattr(transfer_request, 'key', None))
def test_create_zone_transfer_request_scoped(self):
target_project_id = TransferRequestClient.as_user('alt').tenant_id