openstack
/
designate
Code Issues Proposed changes

Implement secure RBAC for top-level domains 

This commit updates the policies for top-level domains to understand
scope checking and account for a read-only role. This is part of a
broader series of changes across OpenStack to provide a consistent
RBAC experience and improve security.

Change-Id: I0df00a826dcaf73c6a078a39585839022b71268a
This commit is contained in:
Lance Bragstad 2020-11-23 21:56:48 +00:00
parent e477cf33b4
commit e99f3588f1
1 changed files with 57 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
designate/common/policies/tld.py
View File

@ -13,65 +13,112 @@
# under the License.
from oslo_log import versionutils
from oslo_policy import policy
from designate.common.policies import base
DEPRECATED_REASON = """
The top-level domain API now supports system scope and default roles.
"""
deprecated_create_tld = policy.DeprecatedRule(
name="create_tld",
check_str=base.RULE_ADMIN
)
deprecated_find_tlds = policy.DeprecatedRule(
name="find_tlds",
check_str=base.RULE_ADMIN
)
deprecated_get_tld = policy.DeprecatedRule(
name="get_tld",
check_str=base.RULE_ADMIN
)
deprecated_update_tld = policy.DeprecatedRule(
name="update_tld",
check_str=base.RULE_ADMIN
)
deprecated_delete_tld = policy.DeprecatedRule(
name="delete_tld",
check_str=base.RULE_ADMIN
)
rules = [
policy.DocumentedRuleDefault(
name="create_tld",
check_str=base.RULE_ADMIN,
check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Create Tld",
operations=[
{
'path': '/v2/tlds',
'method': 'POST'
}
]
],
deprecated_rule=deprecated_create_tld,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name="find_tlds",
check_str=base.RULE_ADMIN,
check_str=base.SYSTEM_READER,
scope_types=['system'],
description="List Tlds",
operations=[
{
'path': '/v2/tlds',
'method': 'GET'
}
]
],
deprecated_rule=deprecated_find_tlds,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name="get_tld",
check_str=base.RULE_ADMIN,
check_str=base.SYSTEM_READER,
scope_types=['system'],
description="Show Tld",
operations=[
{
'path': '/v2/tlds/{tld_id}',
'method': 'GET'
}
]
],
deprecated_rule=deprecated_get_tld,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name="update_tld",
check_str=base.RULE_ADMIN,
check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Update Tld",
operations=[
{
'path': '/v2/tlds/{tld_id}',
'method': 'PATCH'
}
]
],
deprecated_rule=deprecated_update_tld,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name="delete_tld",
check_str=base.RULE_ADMIN,
check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Delete Tld",
operations=[
{
'path': '/v2/tlds/{tld_id}',
'method': 'DELETE'
}
]
],
deprecated_rule=deprecated_delete_tld,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
)
]