From fe5b01d001fc85d0554a88d135dfaf0c27b5d507 Mon Sep 17 00:00:00 2001 From: Gerrit User 32919 <32919@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Tue, 21 Mar 2023 14:42:30 +0000 Subject: [PATCH] Update patch set 8 Patch Set 8: (2 comments) Patch-set: 8 --- 2c935b03e9ad0ec1b877d6ac4bb9720a0cf830b1 | 18 ++++++++++++++++++ 36add1d78a748af671b326833d37f4954afc6294 | 18 ++++++++++++++++++ 2 files changed, 36 insertions(+) diff --git a/2c935b03e9ad0ec1b877d6ac4bb9720a0cf830b1 b/2c935b03e9ad0ec1b877d6ac4bb9720a0cf830b1 index 36ae8149a..19af0e432 100644 --- a/2c935b03e9ad0ec1b877d6ac4bb9720a0cf830b1 +++ b/2c935b03e9ad0ec1b877d6ac4bb9720a0cf830b1 @@ -89,6 +89,24 @@ "revId": "2c935b03e9ad0ec1b877d6ac4bb9720a0cf830b1", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": true, + "key": { + "uuid": "75659c4f_f9e36916", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 7 + }, + "lineNbr": 0, + "author": { + "id": 32919 + }, + "writtenOn": "2023-03-21T14:42:30Z", + "side": 1, + "message": "I had mentioned issues with this approach earlier https://review.opendev.org/c/openstack/designate/+/866698/comments/8bac2428_6de72227", + "parentUuid": "f0c2f782_8dc55899", + "revId": "2c935b03e9ad0ec1b877d6ac4bb9720a0cf830b1", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { diff --git a/36add1d78a748af671b326833d37f4954afc6294 b/36add1d78a748af671b326833d37f4954afc6294 index fd6302300..0b2fed6d0 100644 --- a/36add1d78a748af671b326833d37f4954afc6294 +++ b/36add1d78a748af671b326833d37f4954afc6294 @@ -16,6 +16,24 @@ "message": "This will need to be added to the database as well using alembic.", "revId": "36add1d78a748af671b326833d37f4954afc6294", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "f2daf39a_6ba3df8f", + "filename": "designate/storage/impl_sqlalchemy/tables.py", + "patchSetId": 8 + }, + "lineNbr": 45, + "author": { + "id": 32919 + }, + "writtenOn": "2023-03-21T14:42:30Z", + "side": 1, + "message": "updated", + "parentUuid": "c20dccd8_f381167b", + "revId": "36add1d78a748af671b326833d37f4954afc6294", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file