Commit Graph

4556 Commits (0483a533216c85314a0f3102d6600d12647f0c11)

Author SHA1 Message Date
Zuul 0483a53321 Merge "Fix configuration leak in unit tests" 2022-11-23 06:34:34 +00:00
Zuul 4ecd1089f1 Merge "Add option to force delete zone-files in delete API." 2022-11-23 01:23:51 +00:00
Michael Johnson c3cdc8f2d6 Fix configuration leak in unit tests
There was a configuration leak in the agent based bind 9 tests, where if
you have a /etc/designate/designate.conf file with settings other than
the default the tests would fail.
This patch adds a configuration fixture setting override for the two
tests to ensure consistent testing.

Change-Id: I44dc0499e03431261d5b596206858d94cc4803f9
2022-11-23 01:10:47 +00:00
Erik Olof Gunnar Andersson 03c729c479 Cleaned up and optimized sqlalchemy base
- Cleaned up sql syntax.
- Fixed minor inconsistencies.
- Improved test coverage.

Change-Id: I5986dc9fdd1607119a71872637f836d211186c1e
2022-11-19 04:20:55 +00:00
Zuul b929827271 Merge "Add basic api version test coverage" 2022-11-19 02:24:04 +00:00
Zuul 937e93fe14 Merge "Improved Zone Lock coverage" 2022-11-19 01:44:26 +00:00
Zuul 137cec0c99 Merge "Update metadata in setup.cfg" 2022-11-15 00:39:17 +00:00
dekehn dcb61f7ffe Update metadata in setup.cfg
we are using some "aliases" that the setuptools docs say
"are supported for compatibility reasons" but their use is not


Change-Id: Ib0fac569a255572aa2657fe2a7e4991e30f249de
2022-11-14 22:43:46 +00:00
Scott Solkhon d0e1bb1872 Reload Infoblox config after deleting zone
If you delete a zone using the Infoblox backend
the zone will be deleted from Infoblox but the
zone within OpenStack will go into an ERROR state
unless an operator manually logs into Infoblox
and issues a reload of the running configuration.

This commit fixes this bug by issuing a 'restart
if needed' after deleting the zone. This does not
happen when creating zones as 'restart if needed'
can be passed through as a param into that API call.

Co-Authored-By: Jay Faulkner <>
Change-Id: I296c5f085cce27033461be81ca58c85f095df89a
Closes-Bug: #1840253
2022-11-11 08:03:20 -08:00
Zuul f4999fdfcb Merge "Migrate Designate jobs to run on Ubuntu 22.04 (Jammy)" 2022-11-06 05:19:30 +00:00
OpenStack Proposal Bot 04f8091691 Imported Translations from Zanata
For more information about this automatic import see:

Change-Id: I3a949025b4b93978ab90b0d9e851f02a1c64c69a
2022-11-05 02:51:38 +00:00
Erik Olof Gunnar Andersson fb876d0ddc Add basic api version test coverage
Change-Id: Idb04e81ce5954ca8b5e387dc7c0776fdf7d08779
2022-10-27 15:09:59 +00:00
Erik Olof Gunnar Andersson 664bbb3a87 Improved Zone Lock coverage
Change-Id: I0243a1edfeb7ae592cb77356177df85149bd3055
2022-10-27 15:09:41 +00:00
Dr. Jens Harbott c1a826ac2c Migrate Designate jobs to run on Ubuntu 22.04 (Jammy)
This matches the currently supported LTS platform according to the TC.

Change-Id: I7a5d2fce52841ab057ef1678c6cfb96205033101
2022-10-26 05:17:58 +00:00
Erik Olof Gunnar Andersson 0b162a4c48 Add Ubuntu 22.04 CI support
Change-Id: I04a3a48c7e72797092fd1c3bdc6252085eff04df
2022-10-23 20:08:49 -07:00
Manish Honap d193b0c70c Add option to force delete zone-files in delete API.
Designate does not delete the zone-files on the back-end when zone is
deleted. This results in thousands leftover zone files on backend e.g.
bind. Add option in designate zone delete API to force clean/delete
zone-files on the back-end. This option is restricted for admin or
owner roles.

Closes-Bug: 1966517
Change-Id: Ic7b8fee4d4702b0632774d32542b23d7d2a8c253
2022-10-20 10:01:23 +00:00
Zuul 06b297eaf3 Merge "CI: Move queue configuration into project-template" 2022-10-17 05:56:39 +00:00
OpenStack Proposal Bot 8f7fbc387e Imported Translations from Zanata
For more information about this automatic import see:

Change-Id: I04d433f7f5866e369dc2042110674e9af8fe7664
2022-10-17 03:52:48 +00:00
Zuul 3804048b23 Merge "Removed unused SQL functions and better coverage" 2022-10-15 00:47:50 +00:00
Dr. Jens Harbott c907cfa1e6 CI: Move queue configuration into project-template
With this it can be reused by the other designate repos and we can
reduce the replication everywhere.

Change-Id: I1fe73145e4a4699939244bc857600efa264f2340
2022-10-14 12:15:56 +02:00
Zuul 9386b1ca33 Merge "Fixes compatibility with jsonschema >= 4.16.0" 2022-10-13 11:36:21 +00:00
Michael Johnson d6eabef4de Fixes compatibility with jsonschema >= 4.16.0
Jsonschema has changed the type of a parameter from a simple
tuple to a pyrsistent map object. Since we were passing in the
defaults anyway, this patch removes those parameters from the
jsonschema call. This makes designate compatible with
jsonschema >= 4.16.0.

Closes-Bug: #1992677
Change-Id: I9cc94506a63371ad78b204030e5e87339982e9e7
2022-10-13 06:17:29 +00:00
Zuul 2291f1120c Merge "Increase minimum acceptable test coverage" 2022-10-12 20:45:12 +00:00
Erik Olof Gunnar Andersson 6fee42ecac Remove unicode
No longer necessary as we no longer support Python 2.7.

Change-Id: Icae82ed323d25d85a35e12b8b4c980f0f71d5d85
2022-10-11 16:14:50 +00:00
Erik Olof Gunnar Andersson ab3b57b044 Removed unused SQL functions and better coverage
- Cleaned up indentation.
- Cleaned up sql syntax.
- Fixed minor inconsistencies.

Change-Id: Iea61a0af65afc4bf91c581869984115a6d44011f
2022-10-08 14:51:48 -07:00
Erik Olof Gunnar Andersson d54c10fee2 Increase minimum acceptable test coverage
Change-Id: I196eca62b417cf01b738303442d83a8c0d820e54
2022-10-08 12:04:41 -07:00
OpenStack Proposal Bot 6ca038f350 Imported Translations from Zanata
For more information about this automatic import see:

Change-Id: Id305c536bc78ed8ec07ded59ca6128020800a68a
2022-09-24 02:50:38 +00:00
Zuul e3ac092a30 Merge "Fix mdns test_handler setup" 2022-09-21 06:15:17 +00:00
Michael Johnson e6566f8606 Fix mdns test_handler setup
If the unit tests were run isolated from the larger test suite, the mdns test_handler unit tests would fail with "AssertionError: 'TRANSPORT' must not be None" because the messaging and RPC fixtures were not setup for the test suite.
This patch adds the required test fixtures to the mdns test_handler setUp().

Change-Id: I7edf1e147637b013f35ba47e4d6b92d53d42fe84
2022-09-21 00:55:35 +00:00
Michael Johnson b3e3bbf9e2 Fix minimum versions in requirements.txt
It appears we need to bump some minimum versions for changes made in Zed.
This patch sets:

Change-Id: I3e3e1a4701c52003e4adf2738b1ca8598d4cae47
2022-09-20 17:54:12 +00:00
OpenStack Release Bot b0bff602ed Switch to 2023.1 Python3 unit tests and generic template name
This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for antelope. Also,
updating the template name to generic one.

See also the PTI in governance [1].


Change-Id: I9fb95106665bff1c1c0e323f49afa1a630d4dd0a
2022-09-16 09:19:18 +00:00
OpenStack Release Bot 879d69561c Update master for stable/zed
Add file to the reno documentation build to show release notes for

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on

Sem-Ver: feature
Change-Id: Ifad046c59216d73eaf80b4aaa31ec5824158cfc6
2022-09-16 09:19:16 +00:00
Zuul 2756eadfd3 Merge "Imported Translations from Zanata" 2022-09-16 05:34:56 +00:00
Zuul 3fb9c5220e Merge "fix delete-recordset-response.json format" 2022-09-16 03:55:05 +00:00
OpenStack Proposal Bot c28225652d Imported Translations from Zanata
For more information about this automatic import see:

Change-Id: Ib1184b474cc883fbd63da4ac456fa83a07465767
2022-09-16 03:09:09 +00:00
shanyunfan33 6b740e28e5 fix delete-recordset-response.json format
fix records "", -> ""

Change-Id: I5f15c7f6f9e8d2de49bb30aa2c116619908b846b
2022-09-11 16:53:43 +08:00
Michael Johnson 93dee6a3ff Fix Redis connection over TLS
When Designate is configured to use Redis for coordination over a TLS connection, it will fail to connect with "ssl.SSLError: ('timed out',)".
This is caused by eventlet raising ssl.SSLError instead of the expected socket timeout the core libraries return.
This patch monkey-patches eventlet to return the proper exception.

Closes-Bug: #1989020
Change-Id: I5bd1c10d863212683752e05bb450e6f531ff7e72
2022-09-07 18:42:38 +00:00
Stephen Finucane 7460ae30bf Fix compatibility with oslo.db 12.1.0
oslo.db 12.1.0 has changed the default value for the 'autocommit'
parameter of 'LegacyEngineFacade' from 'True' to 'False'. This is a
necessary step to ensure compatibility with SQLAlchemy 2.0. However,
we are currently relying on the autocommit behavior and need changes to
explicitly manage sessions. Until that happens, we need to override the

Signed-off-by: Stephen Finucane <>
Change-Id: I2e02b00309c8a0289954b7cd6838bd9320cec3e0
2022-09-05 17:20:37 +01:00
Zuul 729e3bf659 Merge "Add backend validation and re-factored pool manage" 2022-09-01 21:31:19 +00:00
Zuul 13a7048814 Merge "Add simple API versioning to the Designate API" 2022-08-31 18:05:26 +00:00
Zuul 218e11ea20 Merge "Switch Designate to Alembic database migrations" 2022-08-30 05:11:25 +00:00
Erik Olof Gunnar Andersson 6d61ad555b Add backend validation and re-factored pool manage
- Added better test coverage.
- Cleaned up error handling.

Closes-Bug: #1987993

Change-Id: I4829c74706e125df5eae25336e13af780cfa304a
2022-08-29 17:14:23 -07:00
Zuul 71c7542a89 Merge "Validate MX records during recordset create or update" 2022-08-29 22:26:14 +00:00
Zuul 3207d71d54 Merge "Imported Translations from Zanata" 2022-08-23 21:16:49 +00:00
Zuul 8ccb3d71c1 Merge "Clean up manage pools and add additional testing" 2022-08-23 07:27:39 +00:00
Zuul e12a356269 Merge "Add additional backend tests" 2022-08-23 05:11:35 +00:00
Erik Olof Gunnar Andersson e65b32a6e6 Clean up manage pools and add additional testing
Change-Id: I6bfe074ec9db9bd95021771b8ffe988f1f23e2be
2022-08-22 21:19:13 -07:00
OpenStack Proposal Bot 4a34f43e52 Imported Translations from Zanata
For more information about this automatic import see:

Change-Id: Ib83f5e1cde009b740ccf01a027bd96bed17c0e97
2022-08-23 03:33:00 +00:00
OpenStack Proposal Bot 925ec43db5 Imported Translations from Zanata
For more information about this automatic import see:

Change-Id: I048f35e7813eb4e2f2b6e4f5259dd4fb2eb3198e
2022-08-22 03:51:54 +00:00
Michael Johnson a03c4657c2 Fix designate-manage pool update MissingProjectID
This patch fixes a bug where adding an additional pool to designate using the "designate-manage pool update" command may fail with an exception:

designate.exceptions.MissingProjectID: A project ID must be specified when not using a project scoped token.

There was an extra check added as part of the scoped token work that a project ID must be provided when creating pools. This was incorrect as pools are still valid with a None project ID as they are a system resource and not tied to a specific project.

This patch removes that check, but retains the RBAC check for and "admin" token.

Closes-Bug: #1986733
Change-Id: I7345d7ef505420767209ba037e3c8930a282d03f
2022-08-16 22:22:19 +00:00