If the record status changes during the removal process,
the current implementation will fail.
Closes-Bug: 2015762
Change-Id: Iebe609e5f365d03e99f2a4580671175b4642763c
When we create a secondary zone, AXFR transfer loops indefinitely.
Normally, only one xfr should be performed.
Due to AXFR loop the zone changes status from active to pending all the time.
Co-Authored-By: ZhouHeng <zhouhenglc@inspur.com>
Closes-Bug: 1856442
Change-Id: I0e0d138049e6d4c31dea3cc6768cc15e59a5942c
This patch moves the responsibility of incrementing the
serial on a zone from central to the producer. This also
means that NOTIFY is triggered by the producer after the
serial has been incremented. The advantage of this approach
is that we can now batch requests which means less work
for the DNS servers, and it removes the risk of
race-conditions when updating the serial. Finally, the
producer is sharded and is easy to scale which means that
this approach should scale well with many zones.
The disadvantage is that it may take up to 5 seconds longer
for the DNS record to be updated on the DNS server. This
can be lowered by increasing the frequency of the task
that is responsible for incrementing the serial.
Depends-On: https://review.opendev.org/#/c/871266/
Change-Id: I5e9733abaaa40c874e1d80d7b57e563df0f12cee
There was a bug that allowed users to create a zone share with the zone
owner. This would then cause issues deleting the zone share as the zone
owner owns the NS and SOA recordsets in the zone.
This patch raises a BadRequest if the user attempts to create a zone
share for the zone owner.
Closes-Bug: #2011585
Change-Id: I1b56c492436821f650d1ba669614d92595d2f476
The python-neutronclient has been deprecated for the CLI since Ocata and
the python bindings "neutronclient" has been deprecated for removal as
of the 2023.1 (Antelope) release[1] in favor of using openstacksdk.
This patch migrates Designate from using the neutronclient to using the
openstacksdk for communicating with neutron.
[1] https://docs.openstack.org/releasenotes/python-neutronclient/2023.1.html
Co-Authored-By: Michael Johnson <johnsomor@gmail.com>
Change-Id: I0198f38afe3d5c32ea06d9e674ab0ff849f360e6
Related-Bug: #1999774
During a grenade upgrade the Designate grenade plugin updates the
python-designateclient. This can cause the installation location to change
to under the /opt/stack/new path.
This patch makes sure we restart neutron q-svc after this update to make sure
it can still find the client.
Change-Id: I5ce96268cb39ae4a4a8d82a75ac192b2310455a1
The backend_url option can sometimes contain secrets.
For example when redis coordination backend is used and authentication
is enabled in redis, the plain redis password is put as an URL element.
[coordination]
backend_url=redis://:password@127.0.0.1:6379
Closes-Bug: #2012246
Change-Id: I0ee95fc56130e51bf5c799d252e79a469492b7db
Add file to the reno documentation build to show release notes for
stable/2023.1.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.1.
Sem-Ver: feature
Change-Id: If35c26f7a55ba18b262d6c3a6cf597a6f17bc9e8
This patch adds a hacking check for line continuation backslashes and fixes the occurences that existed in the code.
Change-Id: I1d1269de231f6e747248a9d816a1d64e3968c69b
The Werkzeug package was included in the designate requirements.txt, but it is
not used by designate.
This patch removes this requirement.
Change-Id: I29b1aba0e8aa455eed7977a5efe887f201963a3c
With this set, if any one of the voting jobs fails, zuul
will report a build failure immediately and abort the remaining
jobs.
This patch enables fail-fast on the gate pipeline as any one
failing job means the patch will not merge.
Change-Id: Ib1872ed973079224f8245eef826399a0b0850f0b
We should not use set_class(), which is deprecated. This fixes it,
by using the element['classes'] directly, as recommended upstream.
Change-Id: I815bc2e8700438f768197337b7afb695a31308d0
This patch marks the agent framework and drivers as deprecated in the Antelope release for removal in the "C" release.
Please see the announcement on the OpenStack discuss mailing list for more information about the deprecation:
https://lists.openstack.org/pipermail/openstack-discuss/2023-January/031803.html
Change-Id: I3a90243dc323a2815ce7d973a5e52248ed1c2ad6
this will allow usage of many oslo.policy scripts, e.g.
to generate current effective policy, or to list redundant polices
defined in policy files.
Change-Id: I1de9b6cc16be2896136c7e99cf150c4b8e4603e9
Closes-Bug: #2004421
The dnspython module >= 2.3.0 now validates the opcodes used when building DNS messages. This breaks Designate because designate is using an "unassigned"[1] opcode 14 for command/control messages inside the backend agents framework.
This patch adds a workaround to override the dnspython opcode enum to include
opcode 14. This will give us time to either remove the agent framework via deprecation or to change the agent framework protocol to not rely on unassigned opcode values.
[1] https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#dns-parameters-5
Partial-Bug: #2002950
Change-Id: If10443b2e361aa1b467fb64124ad3c82540bcddd