designate/releasenotes/notes/Fix-to-address-denylist-invalid-patterns-not-being-checked-ec1f1316ccc6cb1d.yaml
dekehn f44395870d Checks for invalid denylist regex patterns
Adds new field check method DenyListFields to validate
the pattern string. in addition, check for a zero
length string as well.

Closes-Bug: #1934252
Change-Id: I2b69025fc11125bb73a4e0f8c0dedad951399cbf
2022-02-18 19:14:35 +00:00

17 lines
543 B
YAML

---
fixes:
- |
Fixes `bug 1934252`_ which ignored invalid denylist patterns. The fix
entailed checking the pattern string via regular expression compiler and
testing for zero length.
Previously you could create blacklist/denylist using string that cannot
be used either as a regex or as a zone name, for example:
patterns = ['', ``'#(*&^%$%$#@$']``
In addition, the server will return a 400 BadRequest response to an
invalid pattern.
.. _Bug 1934252: https://bugs.launchpad.net/designate/+bug/1934252