openstack
/
devstack-gate
Code Issues Proposed changes

Note status of CINDER_PERIODIC_INTERVAL setting 

Change I1ef1fe564123216b19582262726cdb1078b7650e in DevStack removes
the ability to set the Cinder periodic_interval config option via the
CINDER_PERIODIC_INTERVAL shell var.

The CINDER_PERIODIC_INTERVAL was introduced in DevStack in Havana as
a workaround for Bug #1180976.  That bug, however, was fixed in such
a way that it does not require adjusting the periodic_interval in
Cinder, and the workaround was finally removed in Train.

Because devstack-gate is basically frozen as a legacy pre-zuul-v3
supporting infrastructure for DevStack jobs, this patch does not remove
setting the CINDER_PERIODIC_INTERVAL.  It simply adds a note explaining
that it's a no-op when using a Train or later DevStack.

Depends-on: https://review.opendev.org/#/c/652711
Change-Id: I7e2cc815ad14036dbae94e73d118b2845ddf5c64
Partial-bug: #1824837
This commit is contained in:
Brian Rosmaita 2019-04-24 10:07:09 -04:00
parent 9459f44cb5
commit 5968b7003f
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
devstack-vm-gate.sh
View File

@ -401,6 +401,8 @@ function setup_localrc {
localrc_set "$localrc_file" "LOG_COLOR" "False"
# Don't reset the requirements.txt files after g-r updates
localrc_set "$localrc_file" "UNDO_REQUIREMENTS" "False"
# NOTE(rosmaita): change I1ef1fe564123216b19582262726cdb1078b7650e makes
# the following line a no-op when used with Train or later devstacks
localrc_set "$localrc_file" "CINDER_PERIODIC_INTERVAL" "10"
# TODO(mriedem): Remove OS_NO_CACHE after newton-eol for devstack.
localrc_set "$localrc_file" "export OS_NO_CACHE" "True"