From 52414f5b87eb3084be9bf56a84fecbc9707e0d15 Mon Sep 17 00:00:00 2001 From: Sean Dague Date: Fri, 5 Sep 2014 19:38:38 -0400 Subject: [PATCH] turn off clean log checking The effort to clean out the issues in the logs in OpenStack has largely stalled, and the impact of this is currently just a lot more spurious failures that aren't getting looked at. Also it's kind of a layer violation given that the checker is in Tempest but called from devstack-gate. The number of logs that were actually considered clean is actually very small (only 4 or 5 out of 30), so this wasn't really preventing many new bugs from entering. Removing it will decrease failure rates for tempest runs which otherwise passed. Change-Id: Id236826a1f2669c92b20cf8f07ee604f2c12f06c --- devstack-vm-gate.sh | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/devstack-vm-gate.sh b/devstack-vm-gate.sh index 3101d63a..c17f613e 100755 --- a/devstack-vm-gate.sh +++ b/devstack-vm-gate.sh @@ -413,16 +413,6 @@ if [[ "$DEVSTACK_GATE_TEMPEST" -eq "1" ]]; then sudo -H -u tempest tox -esmoke -- --concurrency=$TEMPEST_CONCURRENCY fi - if [[ "$DEVSTACK_GATE_CLEAN_LOGS" -eq "0" ]] ; then - # if we don't want to enforce clean logs, just turn off - # errexit on this final command - set +o errexit - fi - - echo "Running log checker" - tools/check_logs.py -d $BASE/new/screen-logs - - else # Jenkins expects at least one nosetests file. If we're not running # tempest, then write a fake one that indicates the tests pass (since