From c34b32cf50f2584f721e75c3f519443bcb296c3a Mon Sep 17 00:00:00 2001 From: Sean Dague Date: Wed, 30 Oct 2013 17:40:14 -0400 Subject: [PATCH] Ensure clients get tested correctly in upgrades Client libraries don't have branches, so when a change comes in from python-novaclient the ZUUL_BRANCH is always master. That means we need to actually check to see if ZUUL_BRANCH is BRANCH, not base_branch, which is what we were passed by setup_workspace. Change-Id: I6c7811b279d3450400bb5be140851dbfb52dbc16 --- devstack-vm-gate-wrap.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/devstack-vm-gate-wrap.sh b/devstack-vm-gate-wrap.sh index 1f1a3e40..c6c9b8d2 100755 --- a/devstack-vm-gate-wrap.sh +++ b/devstack-vm-gate-wrap.sh @@ -40,7 +40,7 @@ function git_checkout { } function setup_workspace { - local branch=$1 + local base_branch=$1 local DEST=$2 # Enabled detailed logging, since output of this function is redirected @@ -81,10 +81,10 @@ function setup_workspace { rsync -a ~/workspace-cache/ $DEST/ fi - echo "Using branch: $branch" + echo "Using branch: $base_branch" for PROJECT in $PROJECTS do - BRANCH=$branch + BRANCH=$base_branch echo "Setting up $PROJECT @ $BRANCH" SHORT_PROJECT=`basename $PROJECT` if [[ ! -e $SHORT_PROJECT ]]; then @@ -127,7 +127,7 @@ function setup_workspace { fi # See if we should check out a Zuul ref - if [ "$ZUUL_BRANCH" == "$branch" ]; then + if [ "$ZUUL_BRANCH" == "$BRANCH" ]; then # See if Zuul prepared a ref for this project if { [ "$OVERRIDE_ZUUL_REF" != "" ] && \ git fetch $ZUUL_URL/$PROJECT $OVERRIDE_ZUUL_REF ; } || \