From 4b0f1dc31c1a18eb9e9eb8d85adcf3ae793cef67 Mon Sep 17 00:00:00 2001 From: Anita Kuno Date: Mon, 23 Feb 2015 14:41:04 -0500 Subject: [PATCH] Add a comment for ERROR_ON_CLONE Devstack is currently supporting plugins. As some authors write plugins they try various ways of solving their issue. One author tried to set the value of ERROR_ON_CLONE to FALSE to get their plugin to work. OpenStack gate needs this variable to remain with the value of TRUE. Trying to create a devstack plugin by setting this variable to FALSE is the wrong approach. Change-Id: I9c53980629554ade123381909a9fc6f60666baf7 Reference: https://review.openstack.org/#/c/158075/1 --- devstack-vm-gate.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/devstack-vm-gate.sh b/devstack-vm-gate.sh index 4612da91..049bf987 100755 --- a/devstack-vm-gate.sh +++ b/devstack-vm-gate.sh @@ -127,6 +127,11 @@ SERVICE_PASSWORD=secretservice SERVICE_TOKEN=111222333444 SWIFT_HASH=1234123412341234 ROOTSLEEP=0 +# ERROR_ON_CLONE should never be set to FALSE in gate jobs. +# Setting up git trees must be done by zuul +# because it needs specific git references directly from gerrit +# to correctly do testing. Otherwise you are not testing +# the code you have posted for review. ERROR_ON_CLONE=True ENABLED_SERVICES=$MY_ENABLED_SERVICES SKIP_EXERCISES=$SKIP_EXERCISES