openstack
/
devstack-plugin-ceph
Code Issues Proposed changes

Update patch set 28 

Patch Set 28:

(1 comment)

Patch-set: 28
Attention: {"person_ident":"Gerrit User 4393 \u003c4393@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4393\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 16643 \u003c16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4393\u003e replied on the change"}
This commit is contained in:
Gerrit User 4393 2023-05-23 21:49:42 +00:00 committed by Gerrit Code Review
parent 27d12ae7fd
commit 13c833c643
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
94b582261cc795407188a0479439f36715210691
View File

@ -125,6 +125,24 @@
"revId": "94b582261cc795407188a0479439f36715210691",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5f5dddaa_89b8a89c",
"filename": "devstack/lib/cephadm",
"patchSetId": 25
},
"lineNbr": 136,
"author": {
"id": 4393
},
"writtenOn": "2023-05-23T21:49:42Z",
"side": 1,
"message": "Yeah I guess I\u0027m confused about that part too. Shouldn\u0027t the subnode just need the conf and keys? Why does it need any ceph stuff installed at all? Could be totally my ignorance, but I thought we only need that on the main node where the ceph server side runs and that copying the `/etc/ceph` stuff in the ansible role (which is already happening) should be basically still applicable? Why does deploying ceph with cephadm on the main node change what we need on the subnode for nova, manila, etc?",
"parentUuid": "1145e893_12be3511",
"revId": "94b582261cc795407188a0479439f36715210691",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {