openstack
/
devstack-plugin-ceph
Code Issues Proposed changes

Update patch set 27 

Patch Set 27:

(3 comments)

Patch-set: 27
Attention: {"person_ident":"Gerrit User 4393 \u003c4393@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32594\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 32594 \u003c32594@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_32594\u003e replied on the change"}
This commit is contained in:
Gerrit User 32594 2023-05-23 17:02:22 +00:00 committed by Gerrit Code Review
parent 3e8192ab6f
commit 14ee66e568
1 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
94b582261cc795407188a0479439f36715210691
View File

@ -17,6 +17,24 @@
"revId": "94b582261cc795407188a0479439f36715210691",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e7bdde55_9d73f8a1",
"filename": "devstack/lib/cephadm",
"patchSetId": 25
},
"lineNbr": 136,
"author": {
"id": 32594
},
"writtenOn": "2023-05-23T17:02:22Z",
"side": 1,
"message": "In the case that remote_ceph is true, the command to get to cephadm shell is \"ssh $SSH_USER@$CEPH_IP sudo ${TARGET_BIN}/cephadm\" and that is what im using as $CEPHADM. I need sudo to be part of the command othewise I cant reuse CEPHADM as the situation calls. good thing is that cephadm is /always/ called with sudo so its an easy thing to do.",
"parentUuid": "b976f754_1c80ca65",
"revId": "94b582261cc795407188a0479439f36715210691",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -34,6 +52,24 @@
"revId": "94b582261cc795407188a0479439f36715210691",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "dc2c6e72_ce133342",
"filename": "devstack/lib/cephadm",
"patchSetId": 25
},
"lineNbr": 510,
"author": {
"id": 32594
},
"writtenOn": "2023-05-23T17:02:22Z",
"side": 1,
"message": "ah yes this makes sense, thanks. Havent worked with bash script before this, so I\u0027m learning as go",
"parentUuid": "ab39a40c_0d25f0bf",
"revId": "94b582261cc795407188a0479439f36715210691",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -68,6 +104,24 @@
"parentUuid": "72f57bfb_0c379175",
"revId": "94b582261cc795407188a0479439f36715210691",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4d83021d_800b9904",
"filename": "devstack/lib/cephadm",
"patchSetId": 25
},
"lineNbr": 515,
"author": {
"id": 32594
},
"writtenOn": "2023-05-23T17:02:22Z",
"side": 1,
"message": "So the thought process here is that when the master and subnode are created in parallel like in the case of zuul ci, I need to make sure the node with manila (subnode) waits until ceph is ready on master. this is more to have a waiter than to copy ceph.conf. though that does happen later in post-config",
"parentUuid": "897ee047_856587a5",
"revId": "94b582261cc795407188a0479439f36715210691",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}