Update patch set 28

Patch Set 28:

(2 comments)

Patch-set: 28
Attention: {"person_ident":"Gerrit User 4393 \u003c4393@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4393\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 32594 \u003c32594@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4393\u003e replied on the change"}

94b582261cc795407188a0479439f36715210691

@@ -35,6 +35,24 @@
       "revId": "94b582261cc795407188a0479439f36715210691",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "24cf2225_bc832786",
+        "filename": "devstack/lib/cephadm",
+        "patchSetId": 25
+      },
+      "lineNbr": 136,
+      "author": {
+        "id": 4393
+      },
+      "writtenOn": "2023-05-23T17:32:30Z",
+      "side": 1,
+      "message": "I think you should explicitly put the sudo in the ssh command. However, I still think sshing between the nodes like this is less ideal than letting ansible copy the things that we need (like has been the case for this job for a while).\n\nWhy do you need to ssh to the main node to run `cephadm` commands? Before we just needed ceph config and keys (right?)... what else needs to get run?\n\nPersonally I think that wrapping cephadm in an ssh-to-main-node is likely to be confusing.",
+      "parentUuid": "e7bdde55_9d73f8a1",
+      "revId": "94b582261cc795407188a0479439f36715210691",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {
@@ -122,6 +140,24 @@
       "parentUuid": "897ee047_856587a5",
       "revId": "94b582261cc795407188a0479439f36715210691",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "2e17fb88_513b31db",
+        "filename": "devstack/lib/cephadm",
+        "patchSetId": 25
+      },
+      "lineNbr": 515,
+      "author": {
+        "id": 4393
+      },
+      "writtenOn": "2023-05-23T17:32:30Z",
+      "side": 1,
+      "message": "Yeah I understand that\u0027s what this code inside the function is doing. What I was saying is I don\u0027t see that it actually gets called anywhere. However, I see the call is in `plugin.sh`.",
+      "parentUuid": "4d83021d_800b9904",
+      "revId": "94b582261cc795407188a0479439f36715210691",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }