openstack
/
devstack-plugin-ceph
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(3 comments)

Patch-set: 5
This commit is contained in:
Gerrit User 6984 2016-01-13 11:07:49 +00:00 committed by Gerrit Code Review
parent 88096c4714
commit 9d4f3b3554
1 changed files with 52 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
ba4bd594fd6b1b2360253eb5a8ef5381d6802443
View File

@ -121,6 +121,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_178c2934",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 220,
"author": {
"id": 6984
},
"writtenOn": "2016-01-13T11:07:49Z",
"side": 1,
"message": "we need to check if rgw is enabled prior to attempt to kill it",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_f3775600",
@ -191,6 +208,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_1708a990",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 583,
"author": {
"id": 6984
},
"writtenOn": "2016-01-13T11:07:49Z",
"side": 1,
"message": "we need to check if rgw is enabled prior to attempt to kill it",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_144f4cbe",
@ -226,6 +260,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_f75e35e8",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 616,
"author": {
"id": 6984
},
"writtenOn": "2016-01-13T11:07:49Z",
"side": 1,
"message": "It\u0027s harmless to have ceph-rgw installed but if it\u0027s not need we should not install it. So I\u0027m for a check if rgw is enabled.",
"parentUuid": "da6ed579_5c72c64a",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_1463ccdd",