From aa29fe878264a70d275125ee3699d3b79f99e8f1 Mon Sep 17 00:00:00 2001 From: Gerrit User 4393 <4393@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Wed, 17 May 2023 16:30:59 +0000 Subject: [PATCH] Update patch set 1 Patch Set 1: (1 comment) Patch-set: 1 Attention: {"person_ident":"Gerrit User 9535 \u003c9535@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4393\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 4393 \u003c4393@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4393\u003e replied on the change"} --- bf4598d923bebe9ba31e6651a07596017208b37e | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/bf4598d923bebe9ba31e6651a07596017208b37e b/bf4598d923bebe9ba31e6651a07596017208b37e index 3f448849..3c6e5e31 100644 --- a/bf4598d923bebe9ba31e6651a07596017208b37e +++ b/bf4598d923bebe9ba31e6651a07596017208b37e @@ -17,6 +17,24 @@ "revId": "bf4598d923bebe9ba31e6651a07596017208b37e", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": true, + "key": { + "uuid": "0280bf0e_cd46c949", + "filename": ".zuul.yaml", + "patchSetId": 1 + }, + "lineNbr": 137, + "author": { + "id": 4393 + }, + "writtenOn": "2023-05-17T16:30:59Z", + "side": 1, + "message": "We\u0027re not disabling live migration, we\u0027re disabling *block* migration during live migration. \"Block migration\" means that qemu copies the disks in addition to the memory when it moves the instance. This is only needed/useful for live migration between hosts that do *not* have shared storage. However, this flag _actually_ just enables a flag in tempest to validate a legacy nova api where you tell it what to do instead of it figuring it out itself. So having it enabled causes us to tell nova on shared storage to do something it shouldn\u0027t do in that environment, and is why some tests were failing with \"you asked me to migrate a shared device and I know that\u0027s wrong\".", + "parentUuid": "be210043_445ba0e1", + "revId": "bf4598d923bebe9ba31e6651a07596017208b37e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": false, "key": {