openstack
/
devstack-plugin-ceph
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review+1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 8056 <8056@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
This commit is contained in:
Gerrit User 8056 2016-01-19 09:14:38 +00:00 committed by Gerrit Code Review
parent f1f5c35ed2
commit aec7e3ddfa
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
3d65ac342fd5a417c27a84857b41746886e88c6c Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "ba63e191_d3733a4c",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 12,
"author": {
"id": 8056
},
"writtenOn": "2016-01-19T09:14:38Z",
"side": 1,
"message": "Interesting. I assumed the init_ceph (https://github.com/openstack/devstack-plugin-ceph/blob/master/devstack/lib/ceph#L581 ) called early on in a stack.sh run would kill the daemons,\nhttps://github.com/openstack/devstack-plugin-ceph/blob/master/devstack/plugin.sh#L18\n\nBut yeah, the sequence of cleanup steps is rightly fixed in this patch.",
"revId": "3d65ac342fd5a417c27a84857b41746886e88c6c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}