openstack
/
devstack-plugin-ceph
Code Issues Proposed changes

Update patch set 38 

Patch Set 38:

(3 comments)

Patch-set: 38
Attention: {"person_ident":"Gerrit User 8056 \u003c8056@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Francesco Pantano replied on the change"}
Attention: {"person_ident":"Gerrit User 25402 \u003c25402@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Francesco Pantano replied on the change"}
This commit is contained in:
Gerrit User 25402 2022-03-21 20:06:35 +00:00 committed by Gerrit Code Review
parent 0f0cce3373
commit b670b1356f
1 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
39de5141fdefe2a65ea1e0bf4e12de6398da3f32
View File

@ -34,6 +34,24 @@
"revId": "39de5141fdefe2a65ea1e0bf4e12de6398da3f32",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "7d8d6ec8_4d8ecbdb",
"filename": "devstack/lib/cephadm",
"patchSetId": 37
},
"lineNbr": 320,
"author": {
"id": 25402
},
"writtenOn": "2022-03-21T20:06:35Z",
"side": 1,
"message": "Done",
"parentUuid": "6697270e_3b197344",
"revId": "39de5141fdefe2a65ea1e0bf4e12de6398da3f32",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -51,6 +69,24 @@
"revId": "39de5141fdefe2a65ea1e0bf4e12de6398da3f32",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d616309a_49ec20cc",
"filename": "devstack/lib/cephadm",
"patchSetId": 37
},
"lineNbr": 324,
"author": {
"id": 25402
},
"writtenOn": "2022-03-21T20:06:35Z",
"side": 1,
"message": "oh nice! Thanks for looking into it: given we have multiple_fs enabled by default, I\u0027m going to remove this part in the next PS.",
"parentUuid": "661d7cdb_5d3c109b",
"revId": "39de5141fdefe2a65ea1e0bf4e12de6398da3f32",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -67,6 +103,24 @@
"message": "I think snapshots have been enabled by default for file systems since nautilus. Snapshots for multiple file systems are expected to work since pacific. Maybe you can remove the following too?",
"revId": "39de5141fdefe2a65ea1e0bf4e12de6398da3f32",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b166153a_8d55a649",
"filename": "devstack/lib/cephadm",
"patchSetId": 37
},
"lineNbr": 327,
"author": {
"id": 25402
},
"writtenOn": "2022-03-21T20:06:35Z",
"side": 1,
"message": "Done",
"parentUuid": "f95c9581_9906b49a",
"revId": "39de5141fdefe2a65ea1e0bf4e12de6398da3f32",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}