openstack
/
devstack-plugin-ceph
Code Issues Proposed changes

Update patch set 25 

Patch Set 25:

(1 comment)

Patch-set: 25
This commit is contained in:
Gerrit User 4393 2023-05-23 14:46:02 +00:00 committed by Gerrit Code Review
parent a427d4c612
commit c7f0da6407
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
94b582261cc795407188a0479439f36715210691
View File

@ -50,6 +50,24 @@
"message": "Where is this called from?\n\nI assume it\u0027s going to be from the subnode to the master one? I\u0027m not sure this polling over ssh is really the best way to do it, but I\u0027d have to ask.",
"revId": "94b582261cc795407188a0479439f36715210691",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "897ee047_856587a5",
"filename": "devstack/lib/cephadm",
"patchSetId": 25
},
"lineNbr": 515,
"author": {
"id": 4393
},
"writtenOn": "2023-05-23T14:46:02Z",
"side": 1,
"message": "Yeah, so I think we already have a way to make sure the ceph.conf gets copied from the master node to the subnode:\n\nhttps://opendev.org/openstack/devstack/src/branch/master/roles/sync-controller-ceph-conf-and-keys/tasks/main.yaml\n\nAFAIK, that\u0027s how it happens for the current package-based case. Doing this manually in this code is likely to be less reliable I think.",
"parentUuid": "72f57bfb_0c379175",
"revId": "94b582261cc795407188a0479439f36715210691",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}