From de990173690df158b2f76cb1b231fec8eff8e178 Mon Sep 17 00:00:00 2001
From: Gerrit User 4146 <4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Tue, 23 May 2023 17:45:56 +0000
Subject: [PATCH] Update patch set 28

Patch Set 28:

(1 comment)

Patch-set: 28
CC: Gerrit User 4146 <4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 4393 \u003c4393@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4146\u003e replied on the change"}
---
 94b582261cc795407188a0479439f36715210691 | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/94b582261cc795407188a0479439f36715210691 b/94b582261cc795407188a0479439f36715210691
index 4a66891e..c8a2834d 100644
--- a/94b582261cc795407188a0479439f36715210691
+++ b/94b582261cc795407188a0479439f36715210691
@@ -53,6 +53,24 @@
       "revId": "94b582261cc795407188a0479439f36715210691",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "1bdb1c66_24511584",
+        "filename": "devstack/lib/cephadm",
+        "patchSetId": 25
+      },
+      "lineNbr": 136,
+      "author": {
+        "id": 4146
+      },
+      "writtenOn": "2023-05-23T17:45:56Z",
+      "side": 1,
+      "message": "When devstack-gate and devstack grew multinode support one of the first things we did was give up trying to manually ssh back and forth between nodes and instead rely on ansible for that communications. The major upside for this is you can pretty easily express things like ordering and common tasks without repeating yourself and needing variable overrides like this.\n\nI would recommend you look into using ansible for this instead.\n\nWhere it might get a bit weird is that I think ansible for the most part is driving the devstack shell scripts. What this means is you don\u0027t really write ansible in here instead you would need to write the plugin in such a way that when ansible triggers devstack shell on the controller and computes and storage nodes (I don\u0027t know the actual layout these days) these scripts need to do the correct thing. Basically remove explicit ssh from here and instead operate under the ansible orchestration that is already occuring.",
+      "parentUuid": "24cf2225_bc832786",
+      "revId": "94b582261cc795407188a0479439f36715210691",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {