Update patch set 2
Patch Set 2: > Patch Set 2: > > > Patch Set 2: > > > > > Patch Set 2: > > > > > > Thanks for the review Dmitriy! MDS caps shouldn't be needed for manila in either case. API and scenario tempest tests are passing for both cephfs native and cephfs nfs with the proposed caps. Have you seen an error with this caps in some env? > > > > Hm... But I mean for native case something should create and mount CephFS share? And a new client should be created for each project or smth like that? > > But I think I missed another release note, which would be related to https://opendev.org/openstack/manila/src/branch/master/manila/share/drivers/cephfs/driver.py#L94-L101 > > Nope, you don't need to create the /volumes directory by hand (or with automation) - you needn't do it even previously. "/volumes" was a top level directory that the driver automatically created in the past where it would place all the manila share groups and shares under. Previously the manila CephFS driver would create subdirectories under this top level directory and export them as shares/share groups. However, Ceph now internalized this concept of exporting subdirectories on a filesystem as "Subvolumes". So, Manila shares are now analogous to > "CephFS subvolumes" - a concept that's got growing support in Ceph itself. The top level directory if any is still abstracted away from you as the end user (or the deployer) - you needn't worry about it. > > Is there any place in openstack-ansible where you were creating this top level "/volumes" directory? Yeah, there was as otherwise tempest test was failing back then https://opendev.org/openstack/openstack-ansible-os_manila/src/branch/master/tasks/manila_backend_cephfs.yml#L27-L31. I think it's fixed at the moment anyway, so already suggested patch to drop it Patch-set: 2 Reviewer: Gerrit User 28619 <28619@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=0
This commit is contained in:
Gerrit User 28619
Gerrit Code Review
parent
763955c33a
commit
f73d419a18