c1f66bf283
Patch Set 13:
(1 comment)
Patch-set: 13
Attention: {"person_ident":"Gerrit User 32594 \u003c32594@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_32594\u003e replied on the change"}
68 lines
2.1 KiB
Plaintext
68 lines
2.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "bf9259ee_37133cb3",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 11
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 16643
|
|
},
|
|
"writtenOn": "2024-02-01T23:40:10Z",
|
|
"side": 1,
|
|
"message": "Thanks Ashley,\n\nPlease see comment inline.. \nAre you planning to push a change to update the cephadm image to Reef so we can see the ingress service deployment work?",
|
|
"revId": "034d81b4498c6a88e79e824fc123068c73664c68",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "6e300ed4_03a491c8",
|
|
"filename": "devstack/lib/cephadm",
|
|
"patchSetId": 11
|
|
},
|
|
"lineNbr": 333,
|
|
"author": {
|
|
"id": 16643
|
|
},
|
|
"writtenOn": "2024-02-01T23:40:10Z",
|
|
"side": 1,
|
|
"message": "https://zuul.opendev.org/t/openstack/build/2dab659a894c49e58f79db19568bab4e/log/controller/logs/devstacklog.txt#13158-13160\n\n\nBash can\u0027t perform floating point comparisons like this.. do we just care about this being greater than reef?\n\n```\n if [ \"${ceph_version%%\\.*}\" -ge 18 ]; then\n\n```\n\nshould do the trick",
|
|
"range": {
|
|
"startLine": 333,
|
|
"startChar": 0,
|
|
"endLine": 333,
|
|
"endChar": 41
|
|
},
|
|
"revId": "034d81b4498c6a88e79e824fc123068c73664c68",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "9abf0203_1329160b",
|
|
"filename": "devstack/lib/cephadm",
|
|
"patchSetId": 11
|
|
},
|
|
"lineNbr": 333,
|
|
"author": {
|
|
"id": 32594
|
|
},
|
|
"writtenOn": "2024-02-06T17:50:28Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "6e300ed4_03a491c8",
|
|
"range": {
|
|
"startLine": 333,
|
|
"startChar": 0,
|
|
"endLine": 333,
|
|
"endChar": 41
|
|
},
|
|
"revId": "034d81b4498c6a88e79e824fc123068c73664c68",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |