Add .gitreview file and update puppet coding style

create .gitreview file in devstack-vagrant project.
Put a trailing comma after the final resource parameter.

Change-Id: Ib94efc424180c26b7eb6348baff0eb2385545dcb
Closes-Bug: #1334764

.gitreview

@@ -0,0 +1,4 @@
+[gerrit]
+host=review.openstack.org
+port=29418
+project=openstack-dev/devstack-vagrant.git

puppet/manifests/cleanup.pp

@@ -1,19 +1,19 @@
 node default {
   $dir = '/home/stack/devstack'
 
-  file {"/etc/hostname":
+  file { '/etc/hostname':
     ensure => absent
   }
 
-  file {"/etc/udev/rules.d/70-persistent-net.rules":
+  file { '/etc/udev/rules.d/70-persistent-net.rules':
     ensure => absent
   }
 
-  exec {"clean.sh":
+  exec { 'clean.sh':
     cwd => $dir,
-    path => "/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:.",
+    path => '/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:.',
     user => 'stack',
-    command => "$dir/clean.sh",
+    command => "${dir}/clean.sh",
-    logoutput => "on_failure",
+    logoutput => 'on_failure',
   }
 }

puppet/manifests/default.pp

@@ -1,10 +1,10 @@
 node default {
   include base
   include user::stack
-  if $setup_mode == "grenade" {
+  if $setup_mode == 'grenade' {
     include grenade
   }
-  if $setup_mode == "devstack" {
+  if $setup_mode == 'devstack' {
     include devstack
   }
 }

puppet/modules/base/manifests/init.pp

@@ -1,27 +1,30 @@
+# == Class: base
+#
+
 class base {
 
-  $vim = $operatingsystem ? {
+  $vim = $::operatingsystem ? {
-    /RedHat|Fedora|Centos/ => "vim-enhanced",
+    /RedHat|Fedora|Centos/ => 'vim-enhanced',
-    default => "vim"
+    default => 'vim',
   }
 
-  $editors = ["joe", $vim]
+  $editors = ['joe', $vim]
-  $vcs = ["git"]
+  $vcs = ['git']
 
-  package {$editors:
+  package { $editors:
     ensure => latest
   }
 
-  package {$vcs:
+  package { $vcs:
     ensure => latest
   }
 
-  file { "/usr/local/bin/git_clone.sh":
+  file { '/usr/local/bin/git_clone.sh':
-    owner => "root",
+    owner => 'root',
-    group => "root",
+    group => 'root',
-    mode  => 755,
+    mode => '0755',
-    source => "puppet:///modules/base/git_clone.sh",
+    source => 'puppet:///modules/base/git_clone.sh',
-    require => Package[$vcs]
+    require => Package[$vcs],
   }
 
 }

puppet/modules/devstack/manifests/init.pp

@@ -1,3 +1,6 @@
+# == Class: devstack
+#
+
 class devstack(
   $dir = '/home/stack/devstack'
 )
@@ -16,42 +19,42 @@ class devstack(
     $branch = 'master'
   }
 
-  exec { "devstack_clone":
+  exec { 'devstack_clone':
-    require => File["/usr/local/bin/git_clone.sh"],
+    require => File['/usr/local/bin/git_clone.sh'],
-    path => "/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:.",
+    path => '/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:.',
     environment => "HOME=/home/$user",
     user => 'stack',
     group => 'stack',
     command => "/usr/local/bin/git_clone.sh ${source} ${branch} ${dir}",
     logoutput => true,
-    timeout => 1200
+    timeout => 1200,
   }
 
   file { "$dir/local.sh":
     owner => $user,
     group => $user,
-    mode  => 755,
+    mode => '0755',
-    source => "puppet:///modules/devstack/local.sh",
+    source => 'puppet:///modules/devstack/local.sh',
-    require => Exec[ "devstack_clone" ]
+    require => Exec['devstack_clone'],
   }
 
   file { "$dir/local.conf":
     owner => $user,
     group => $user,
-    mode  => 644,
+    mode => '0644',
     content => template('devstack/local.erb'),
-    require => File["$dir/local.sh"]
+    require => File["$dir/local.sh"],
   }
 
-  exec {"stack.sh":
+  exec { 'stack.sh':
-    require => [ File["$dir/local.conf"], File["$dir/local.sh"] ],
+    require => [File["$dir/local.conf"], File["$dir/local.sh"]],
     cwd => $dir,
-    path => "/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:.",
+    path => '/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:.',
     environment => "HOME=/home/$user",
     user => 'stack',
     group => 'stack',
     command => "$dir/stack.sh",
     logoutput => true,
-    timeout => 0
+    timeout => 0,
   }
 }

puppet/modules/grenade/manifests/init.pp

@@ -1,3 +1,6 @@
+# == Class: grenade
+#
+
 class grenade(
   $dir = '/home/stack/grenade'
 )
@@ -16,15 +19,15 @@ class grenade(
     $branch = 'master'
   }
 
-  exec { "grenade_clone":
+  exec { 'grenade_clone':
-    require => File["/usr/local/bin/git_clone.sh"],
+    require => File['/usr/local/bin/git_clone.sh'],
-    path => "/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:.",
+    path => '/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:.',
     environment => "HOME=/home/$user",
     user => 'stack',
     group => 'stack',
     command => "/usr/local/bin/git_clone.sh ${source} ${branch} ${dir}",
     logoutput => true,
-    timeout => 1200
+    timeout => 1200,
   }
 
   # file { "$dir/localrc":
@@ -35,10 +38,10 @@ class grenade(
   #   require => File["$dir/local.sh"]
   # }
 
-  exec {"grenade.sh":
+  exec { 'grenade.sh':
-    require => [ Exec["grenade_clone"] ],
+    require => Exec['grenade_clone'],
     cwd => $dir,
-    path => "/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:.",
+    path => '/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:.',
     environment => "HOME=/home/$user",
     user => 'stack',
     group => 'stack',

puppet/modules/user/manifests/create.pp

@@ -1,10 +1,13 @@
+# == Class: user::create
+#
+
 define user::create (
-  $user = "",
+  $user = '',
-  $pass = "",
+  $pass = '',
-  $key = "",
+  $key = '',
-  $key_type = "rsa",
+  $key_type = 'rsa',
   $home = "/home/${user}",
-  $is_admin = false
+  $is_admin = false,
 )
 {
   if $is_admin == true {
@@ -14,49 +17,49 @@ define user::create (
     $extra_groups = ['dialout']
   }
 
-  group {$extra_groups:
+  group { $extra_groups:
     ensure => present,
   } ->
 
-  group {$user:
+  group { $user:
     ensure => present,
   } ->
 
-  user {$user:
+  user { $user:
+    ensure => present,
     gid => $user,
     password => $pass,
     home => $home,
     groups => $extra_groups,
-    ensure => present,
+    shell => '/bin/bash'
-    shell => "/bin/bash"
   } ->
 
   file { $home:
+    ensure => directory,
     owner => $user,
     group => $user,
-    mode => 755,
+    mode => '0755',
-    ensure => directory,
   } ->
 
   file { "${home}/bin":
+    ensure => directory,
     owner => $user,
     group => $user,
-    mode => 755,
+    mode => '0755',
-    ensure => directory,
   } ->
 
   file { "${home}/.ssh":
+    ensure => directory,
     owner => $user,
     group => $user,
-    mode => 700,
+    mode => '0700',
-    ensure => directory,
   } ->
 
   ssh_authorized_key { $user:
+    ensure => present,
     key => $key,
     user => $user,
     type => $key_type,
-    ensure => present
   }
 
 }

puppet/modules/user/manifests/stack.pp

@@ -1,21 +1,24 @@
+# == Class: user::stack
+#
+
 class user::stack(
   $username = 'stack'
 )
 {
 
-  notify {'after':
+  notify { 'after':
     message => "User params: u => $username, p => $stack_pass, k => $stack_sshkey"
   }
 
 
-  file {'/etc/sudoers.d/stack':
+  file { '/etc/sudoers.d/stack':
-    owner => "root",
+    owner => 'root',
-    group => "root",
+    group => 'root',
-    mode  => 440,
+    mode => '0440',
-    source => "puppet:///modules/user/stack_sudoers"
+    source => 'puppet:///modules/user/stack_sudoers',
   } ->
 
-  user::create {'stack':
+  user::create { 'stack':
     user => $username,
     pass => $stack_pass,
     key => $stack_sshkey,
@@ -25,8 +28,8 @@ class user::stack(
   file {'/home/stack/.bashrc':
     owner => $username,
     group => $username,
-    mode  => 644,
+    mode => '0644',
-    source => "puppet:///modules/user/stack_bashrc"
+    source => 'puppet:///modules/user/stack_bashrc',
   }
 
 }