From 237225dd394d43e17c5406c8c0549e3e7d5e4cd2 Mon Sep 17 00:00:00 2001 From: Attila Fazekas Date: Wed, 6 Nov 2013 15:41:04 +0100 Subject: [PATCH] Fixing space issues between " and ] When we are using '[' aka. ``test`` , before the closing ']' we need to use a space. Otherwise the commands return with '2' so the "expression" will be a constant false. Change-Id: I673762e802c28335e03390b6608cf6bbee6aaba6 --- functions | 2 +- tools/build_ramdisk.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/functions b/functions index 0a73b9f0ac..197b4cca17 100644 --- a/functions +++ b/functions @@ -1266,7 +1266,7 @@ function setup_develop() { # where we really really want the overridden version to stick. So provide # a variable that tells us whether or not we should UNDO the requirements # changes (this will be set to False in the OpenStack ci gate) - if [ $UNDO_REQUIREMENTS = "True"]; then + if [ $UNDO_REQUIREMENTS = "True" ]; then if [ $update_requirements -eq 0 ]; then (cd $project_dir && git reset --hard) fi diff --git a/tools/build_ramdisk.sh b/tools/build_ramdisk.sh index 3d9f76f4a5..737255578a 100755 --- a/tools/build_ramdisk.sh +++ b/tools/build_ramdisk.sh @@ -22,7 +22,7 @@ cleanup() { umount $MNTDIR rmdir $MNTDIR fi - if [ -n "$DEV_FILE_TMP" -a -e "$DEV_FILE_TMP "]; then + if [ -n "$DEV_FILE_TMP" -a -e "$DEV_FILE_TMP" ]; then rm -f $DEV_FILE_TMP fi if [ -n "$IMG_FILE_TMP" -a -e "$IMG_FILE_TMP" ]; then