diff --git a/tools/xen/functions b/tools/xen/functions index 4e37554f4d..e5a7531a41 100644 --- a/tools/xen/functions +++ b/tools/xen/functions @@ -40,11 +40,11 @@ function extract_remote_zipball { local LOCAL_ZIPBALL=$(mktemp) local EXTRACTED_FILES=$(mktemp -d) - ( + { wget -nv $ZIPBALL_URL -O $LOCAL_ZIPBALL --no-check-certificate unzip -q -o $LOCAL_ZIPBALL -d $EXTRACTED_FILES rm -f $LOCAL_ZIPBALL - ) >&2 + } >&2 echo "$EXTRACTED_FILES" } diff --git a/tools/xen/mocks b/tools/xen/mocks index 6da6acbba7..94b0ca4d02 100644 --- a/tools/xen/mocks +++ b/tools/xen/mocks @@ -34,6 +34,9 @@ function mktemp { } function wget { + if [[ $@ =~ "failurl" ]]; then + exit 1 + fi echo "wget $@" >> $LIST_OF_ACTIONS } diff --git a/tools/xen/test_functions.sh b/tools/xen/test_functions.sh index 410df5f8b7..534723833d 100755 --- a/tools/xen/test_functions.sh +++ b/tools/xen/test_functions.sh @@ -173,6 +173,15 @@ EOF [ "$RESULT" = "tempdir" ] } +function test_extract_remote_zipball_wget_fail { + set +e + + local IGNORE + IGNORE=$(. mocks && extract_remote_zipball "failurl") + + assert_previous_command_failed +} + function test_find_nova_plugins { local tmpdir=$(mktemp -d)