From 8dad4bde886ed2a5bb28d8eb43cfa874ee81c790 Mon Sep 17 00:00:00 2001 From: Arnaud Legendre Date: Mon, 3 Feb 2014 17:57:39 -0800 Subject: [PATCH] upload_image.sh to support streamOptimized disks The current version of the script will use "preallocated" as the disk type of a stream optimized disk. This needs to be fixed by introspecting the createType of the vmdk file. Closes-Bug: #1275993 Change-Id: I98594acecf26dd1164870f43890254a19ef23fe9 --- functions | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/functions b/functions index 73d65ce15b..281b6767c5 100644 --- a/functions +++ b/functions @@ -1450,7 +1450,7 @@ function upload_image() { # vmdk disk type vmdk_create_type="$(head -25 $IMAGE | grep -a -F -m 1 'createType=' $IMAGE)" vmdk_create_type="${vmdk_create_type#*\"}" - vmdk_create_type="${vmdk_create_type%?}" + vmdk_create_type="${vmdk_create_type%\"*}" descriptor_data_pair_msg="Monolithic flat and VMFS disks "` `"should use a descriptor-data pair." @@ -1495,6 +1495,8 @@ function upload_image() { IMAGE_NAME="${flat_fname}" fi vmdk_disktype="preallocated" + elif [[ "$vmdk_create_type" = "streamOptimized" ]]; then + vmdk_disktype="streamOptimized" elif [[ -z "$vmdk_create_type" ]]; then # *-flat.vmdk provided: attempt to retrieve the descriptor (*.vmdk) # to retrieve appropriate metadata @@ -1533,10 +1535,8 @@ function upload_image() { vmdk_adapter_type="${vmdk_adapter_type%?}" fi fi - #TODO(alegendre): handle streamOptimized once supported by the VMware driver. vmdk_disktype="preallocated" else - #TODO(alegendre): handle streamOptimized once supported by the VMware driver. vmdk_disktype="preallocated" fi