openstack/diskimage-builder
Code Issues Proposed changes

Source img-functions into common-functions.

Browse Source 
A recent commit added a call to function cleanup_dirs to
the common-functions file, but this function is not in scope
for all code paths.

The problem can be reproduced like so:
  bin/ramdisk-image-create deploy -o /tmp/foo

Which results in the error:
  bin/../lib/common-functions: line 35: cleanup_dirs: command not found

This change causes cleanup_dirs to be in scope when calling ramdisk-image-create.

Change-Id: Iaf01beb9dd42a9d810d8aed1aa4ce19a5854c09b
This commit is contained in:
Tim Miller 2013-04-30 19:36:37 -07:00
parent 39152c1b30
commit 7ef33c51db
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/common-functions
View File

@ -13,6 +13,8 @@
# License for the specific language governing permissions and limitations
# under the License.
source $(dirname $(readlink -f $BASH_SOURCE))/img-functions
function mk_build_dir () {
export TMP_BUILD_DIR=$(mktemp -t -d --tmpdir=${TMP_DIR:-/tmp} image.XXXXXXXX)
[ $? -eq 0 ] || die "Failed to create tmp directory"