openstack/diskimage-builder
Code Issues Proposed changes

Update tracing in block_device_create_config_file

Browse Source 
Something seems to be going on with the ppc matching in the gate test.
Small updates to see what's going on...

Change-Id: Ie48cd4ce1f983a58932a577a43746240f6866936
This commit is contained in:
Ian Wienand 2017-06-06 09:43:44 +10:00
parent 7661da1341
commit 89a85f6fbb
1 changed files with 36 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
diskimage_builder/lib/common-functions
View File

@ -389,34 +389,56 @@ function unmount_dir {
# Parameters: # Parameters:
# - name of the to be created config file # - name of the to be created config file
function block_device_create_config_file { function block_device_create_config_file {
local CONFIG_YAML="$1" # nosiy; we manually trace
local xtrace
xtrace=$(set +o | grep xtrace)
set +o xtrace
local config_yaml="$1"
# User setting overwrites this
if [[ ${DIB_BLOCK_DEVICE_CONFIG:-} == file://* ]]; then if [[ ${DIB_BLOCK_DEVICE_CONFIG:-} == file://* ]]; then
cp $(echo ${DIB_BLOCK_DEVICE_CONFIG} | cut -c 8-) ${CONFIG_YAML} cp $(echo ${DIB_BLOCK_DEVICE_CONFIG} | cut -c 8-) ${config_yaml}
echo "Using file-based block-device config: ${DIB_BLOCK_DEVICE_CONFIG}"
return return
fi fi
if [ -n "${DIB_BLOCK_DEVICE_CONFIG:-}" ]; then if [ -n "${DIB_BLOCK_DEVICE_CONFIG:-}" ]; then
printf "%s" "${DIB_BLOCK_DEVICE_CONFIG}" >${CONFIG_YAML} printf "%s" "${DIB_BLOCK_DEVICE_CONFIG}" >${config_yaml}
echo "User specified block-device config from DIB_BLOCK_DEVICE_CONFIG"
return return
fi fi
# Search the elements for a matching block-device config.
# XXX: first match wins?
echo "Searching elements for block-device[-${ARCH}].yaml ..."
eval declare -A image_elements=($(get_image_element_array)) eval declare -A image_elements=($(get_image_element_array))
for i in ${!image_elements[@]}; do for i in ${!image_elements[@]}; do
local BLOCK_DEVICE_CFG_PATH=${image_elements[$i]}/block-device-${ARCH}.yaml local cfg
if [ -e ${BLOCK_DEVICE_CFG_PATH} ]; then # look for arch specific version first, then default
cp ${BLOCK_DEVICE_CFG_PATH} ${CONFIG_YAML} cfg=${image_elements[$i]}/block-device-${ARCH}.yaml
if [ -e ${cfg} ]; then
cp ${cfg} ${config_yaml}
echo "Using block-device config: ${cfg}"
return
else else
BLOCK_DEVICE_CFG_PATH=${image_elements[$i]}/block-device-default.yaml cfg=${image_elements[$i]}/block-device-default.yaml
if [ -e ${BLOCK_DEVICE_CFG_PATH} ]; then if [ -e ${cfg} ]; then
cp ${BLOCK_DEVICE_CFG_PATH} ${CONFIG_YAML} cp ${cfg} ${config_yaml}
echo "Using block-device config: ${cfg}"
return
fi fi
fi fi
done done
echo "... done"
# how did this get here?
if [ -e ${config_yaml} ]; then
die "${config_yaml} exists?"
fi
echo "Using default block-device fallback config"
# If no config is there (until now) use the default config # If no config is there (until now) use the default config
if [ ! -e ${CONFIG_YAML} ]; then
cat >${CONFIG_YAML} <<EOF cat >${config_yaml} <<EOF
- local_loop: - local_loop:
name: image0 name: image0
mkfs: mkfs:
@ -427,5 +449,6 @@ function block_device_create_config_file {
options: "defaults" options: "defaults"
fsck-passno: 1 fsck-passno: 1
EOF EOF
fi
$xtrace
} }