openstack/diskimage-builder
Code Issues Proposed changes
18df5a59b5
diskimage-builder/diskimage_builder/elements/sysprep
History
Logan V c7e907794c Ensure machine-id is not included in images 
Two bugs are addressed.

1) The sysprep element was broken in that it only truncates
   /etc/machine-id, but not /var/lib/dbus/machine-id. systemd will
   not generate a new machine-id if /var/lib/dbus/machine-id is
   present[1], it will simply copy it to /etc/machine-id.

   We observed machine-ids being packaged in /var/lib/dbus/machine-id
   on several distros: Ubuntu Bionic, Fedora 29, Debian Stretch.

   CentOS 7 and Ubuntu Xenial do not contain packaged machine-id as
   far as I can tell.

   All test builds were performed using -minimal elements.

2) A second bug existed where debian-minimal did not run the sysprep
   element at all, so a stretch image I tested contained a populated
   /etc/machine-id AND a populated /var/lib/dbus/machine-id.

[1] https://www.freedesktop.org/software/systemd/man/machine-id.html#Initialization

Change-Id: Ibb28b6e90d966a845de38a2cd5a1e8babd2604bc
2019-09-20 03:17:50 +00:00
..
finalise.d Ensure machine-id is not included in images 2019-09-20 03:17:50 +00:00
README.rst Clear /etc/machine-id to avoid duplicate machine-ids 2017-08-06 13:56:58 -04:00

README.rst

sysprep

This element holds configuration and scripts that are common for all distributions.