From 82d872cc99d8f9919f16ded304f06aa65fad8fb4 Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Mon, 21 Oct 2024 20:16:05 +0900 Subject: [PATCH] Use pre-commit to run pep8 tests Change-Id: I063584d84d52fa144b1e5d98b503e312d320bf68 --- .pre-commit-config.yaml | 26 ++++++++++++++++++++++++++ doc/source/conf.py | 0 doc/source/usage.rst | 2 +- test-requirements.txt | 2 -- tox.ini | 5 ++++- 5 files changed, 31 insertions(+), 4 deletions(-) create mode 100644 .pre-commit-config.yaml mode change 100755 => 100644 doc/source/conf.py diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml new file mode 100644 index 0000000..ab651e2 --- /dev/null +++ b/.pre-commit-config.yaml @@ -0,0 +1,26 @@ +repos: + - repo: https://github.com/pre-commit/pre-commit-hooks + rev: v5.0.0 + hooks: + - id: trailing-whitespace + # Replaces or checks mixed line ending + - id: mixed-line-ending + args: ['--fix', 'lf'] + exclude: '.*\.(svg)$' + # Forbid files which have a UTF-8 byte-order marker + - id: check-byte-order-marker + # Checks that non-binary executables have a proper shebang + - id: check-executables-have-shebangs + # Check for files that contain merge conflict strings. + - id: check-merge-conflict + # Check for debugger imports and py37+ breakpoint() + # calls in python source + - id: debug-statements + - id: check-yaml + files: .*\.(yaml|yml)$ + - repo: https://opendev.org/openstack/hacking + rev: 7.0.0 + hooks: + - id: hacking + additional_dependencies: [] + exclude: '^(doc|releasenotes|tools)/.*$' diff --git a/doc/source/conf.py b/doc/source/conf.py old mode 100755 new mode 100644 diff --git a/doc/source/usage.rst b/doc/source/usage.rst index 4486e94..d314f25 100644 --- a/doc/source/usage.rst +++ b/doc/source/usage.rst @@ -7,7 +7,7 @@ You can find examples in ``etcd3gw/examples`` and look at ``etcd3gw/client.py``. Basic usage example:: from etcd3gw.client import Etcd3Client - + client = Etcd3Client(host='localhost', port=2379) # Put key diff --git a/test-requirements.txt b/test-requirements.txt index 01725a4..fdb190d 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -1,5 +1,3 @@ -hacking>=6.1.0,<6.2.0 # Apache-2.0 - coverage>=4.0 # Apache-2.0 python-subunit>=0.0.18 # Apache-2.0/BSD oslotest>=1.10.0 # Apache-2.0 diff --git a/tox.ini b/tox.ini index b339ca0..4e8cc12 100644 --- a/tox.ini +++ b/tox.ini @@ -10,7 +10,10 @@ deps = -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/up commands = py.test -vv {posargs} [testenv:pep8] -commands = flake8 {posargs} +deps = + pre-commit +commands = + pre-commit run --all-files --show-diff-on-failure [testenv:venv] commands = {posargs}