From e9e2a3769c2f7065da2a9be1839fd6910b9a4b9f Mon Sep 17 00:00:00 2001 From: chao liu Date: Mon, 29 Jan 2018 05:21:57 -0800 Subject: [PATCH] use . instead of source. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Code conventions: Use “.” to source script files When you have to source a script file, for example , a credentials file to gain access to user-only or admin-only CLI commands, use . instead of source. See more: http://docs.openstack.org/contributor-guide/writing-style/code-conventions Change-Id: If2ef1f3f56008f7e9e1bec13b94d542a3b9667e7 --- devstack/plugin.sh | 2 +- tools/with_venv.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/devstack/plugin.sh b/devstack/plugin.sh index c3a9ee2..7b4a886 100644 --- a/devstack/plugin.sh +++ b/devstack/plugin.sh @@ -16,7 +16,7 @@ if is_service_enabled freezer-web-ui; then if [[ "$1" == "source" || "`type -t install_freezer_web_ui`" != 'function' ]]; then # Initial source - source $FREEZER_WEB_UI_DIR/devstack/lib/freezer-web-ui + . $FREEZER_WEB_UI_DIR/devstack/lib/freezer-web-ui fi if [[ "$1" == "stack" && "$2" == "install" ]]; then diff --git a/tools/with_venv.sh b/tools/with_venv.sh index b15965f..99c1d35 100755 --- a/tools/with_venv.sh +++ b/tools/with_venv.sh @@ -4,4 +4,4 @@ VENV_PATH=${VENV_PATH:-${TOOLS_PATH}} VENV_DIR=${VENV_NAME:-/../.venv} TOOLS=${TOOLS_PATH} VENV=${VENV:-${VENV_PATH}/${VENV_DIR}} -source ${VENV}/bin/activate && "$@" \ No newline at end of file +. ${VENV}/bin/activate && "$@"