In function snapshot.lvm.get_lvm_info(), filter null string members
before return the mountpoint list.
Change-Id: Iae07dd081cafe92fa63c90a0d4bf967ec7206ea5
Closes-Bug:1874492
Before umounting and removing lvm volume, we need to make sure we are
not within the mount point that is to be removed.
Previous logic lacks consideration that path can have parts like
trailing slashes, which could end up skipping changing dir when it is
needed.
This patch proposes to normalize the path before doing the check to
avoid such mistakes.
Closes-Bug: #1799334
Story: 2004153
Task: 27625
Change-Id: Iaa8c8ff523b1d29a1addeaa3d802053d63aba80a
For the time being, the path_to_backup for backup with lvm snapshot
is not taken directly from --path-to-backup parameter, but adjusted
according the mount info of the corresponding volume hinted by that
parameter. However this info is inferred before the volume is actually
mounted so it tends to be inaccuate and leads to errors.
So do the calculation after volume mounting instead.
Change-Id: I0d7f3125520aa27ba1d2d94ff52e3cc0eea4916c
Closes-Bug: #1799183
Story: 2004152
Task: 27623
license boilerplates as docstring are included in automatically
generated documentation which leads to wrong formatting.
For example the indented hyperlink to the license is formatted as
quotation.
Change-Id: I9d6088ab48d6787f29b593bfa5445b6a84e99de7
Enable treading warnings as errors so that no new broken stuff gets
merged. Remove obsolete way of doing it, it's a nop.
Fix bugs found:
* Add missing sphinx modules to properly generate content.
* Misformatting of comments and files
* Do not index the windows modules, they import modules that do not
exist on Linux.
* Place api docs in reference/api according to
http://specs.openstack.org/openstack/docs-specs/specs/pike/os-manuals-migration.html
and reference it. Update .gitignore for this.
* Include missing files in tree.
Change-Id: I57d3124ac9571f189cd0e10e4cf7e805b8e09045
Openstack common has a wrapper for generating uuids. We should
use that function when generating uuids for consistency.
Change-Id: Ide5cdaf48a27e9c080fd8691b100a601f82ca2bf
Closes-Bug: #1082248
Standardize on oslo.log.
Log exception stack traces where appropriate.
Add logging to all files.
Remove '[*]' from log messages.
Log command line arguments at Freezer Agent start
so that errors can be traced to specific invocations.
Leave scheduler module mostly unchanged because it
is doing python logging configuration.
Change-Id: I23de0558409e63978303963d592a4e5ee4dee2b5
Remove select line in tox.ini.
Currently checks are not being run.
Run pep8 checks.
Fix code to pass pep8 checks.
Change-Id: Iacef4386b1214f95b1bd106c17a5f714f948a1a1
Closes-Bug: #1593452
If a '%' is part of the freezer option --lvm-snapsize
--extends option will be used instead of --size for the snapshot.
Change-Id: Iffe579c01c385fcea215639cf445f56d3403e9a5
Implements: lvm-size-percentage
1) new snapshot module with code vss,
lvm and part of backup.py -
create_snapshot and remove_snapshot
This module should contain all code related shadow,
vss and any new snapshots.
2) new openstack module with code from osclient,
restore and backup (BackupOS)
This module should contain code related to cinder/nova backups
3) new utils module with code from utils, win_utils,
bandwidth, config, exec_cmd, validator, streaming
This module should containd code related to anything
that cannot be extracted to its own module
4) new test modules - snapshot, utils, openstack and apiclient.
Test scheduler daemon is now located in scheduler module.
5) Backup.py is deleted and code placed to
openstack.backup (BackupOS) and to job.BackupJob
Change-Id: I46194b40b3a65c15b6095cfb7388dcfd30d95997
Haosheng He