From 9e1e030c98ecccae640285bd2b38d19124d688e5 Mon Sep 17 00:00:00 2001 From: Cady_Chen Date: Tue, 20 Dec 2016 01:33:05 +0800 Subject: [PATCH] Use assertIsNone(...) instead of assertEqual(None, ...) Refer to:http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises [H203] Use assertIs(Not)None to check for None (off by default) Unit test assertions tend to give better messages for more specific assertions. As a result, assertIsNone(...) is preferred over assertEqual(None, ...) and assertIs(None, ...) Change-Id: I9246fac952c59d3ddc1458c16c53fc988ac095d3 --- fuel_agent/tests/test_partition.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fuel_agent/tests/test_partition.py b/fuel_agent/tests/test_partition.py index 2362d36d..037c0af8 100644 --- a/fuel_agent/tests/test_partition.py +++ b/fuel_agent/tests/test_partition.py @@ -256,7 +256,7 @@ class TestParted(unittest2.TestCase): def test_next_name_none(self, nt_mock, nc_mock): nc_mock.return_value = 1 nt_mock.return_value = 'extended' - self.assertEqual(None, self.prtd.next_name()) + self.assertIsNone(self.prtd.next_name()) @mock.patch.object(objects.Parted, 'next_count') @mock.patch.object(objects.Parted, 'next_type')