98 lines
3.4 KiB
Plaintext
98 lines
3.4 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "5a8bc5a2_c82e3e42",
|
|
"filename": "fuel_agent/utils/grub.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 30,
|
|
"author": {
|
|
"id": 8003
|
|
},
|
|
"writtenOn": "2016-09-27T12:04:34Z",
|
|
"side": 0,
|
|
"message": "could it fixed by re-ordering these paths?\n\nso, for *grub2* methods, any path with `grub2` will be checked first.",
|
|
"range": {
|
|
"startLine": 30,
|
|
"startChar": 21,
|
|
"endLine": 30,
|
|
"endChar": 66
|
|
},
|
|
"revId": "8125d9ecd537825492669f5d52c68cd179143a0f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a8bc5a2_77526768",
|
|
"filename": "fuel_agent/utils/grub.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 30,
|
|
"author": {
|
|
"id": 21284
|
|
},
|
|
"writtenOn": "2016-09-27T13:27:07Z",
|
|
"side": 0,
|
|
"message": "I was thinking about just changing the order here. This makes this method more cryptic, rather than straightforward approach, that this patch aims (if we deal with centos6, then grub is 1 and location is /boot/grub/grub.cfg, if centos7 - 2 and /boot/grub2/grub.cfg, ubuntu - 2 and /boot/grub/grub.conf).\nBut I\u0027m ok if you insist about just changing the order.",
|
|
"parentUuid": "5a8bc5a2_c82e3e42",
|
|
"range": {
|
|
"startLine": 30,
|
|
"startChar": 21,
|
|
"endLine": 30,
|
|
"endChar": 66
|
|
},
|
|
"revId": "8125d9ecd537825492669f5d52c68cd179143a0f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a8bc5a2_806b2684",
|
|
"filename": "fuel_agent/utils/grub.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 30,
|
|
"author": {
|
|
"id": 8003
|
|
},
|
|
"writtenOn": "2016-09-27T14:28:26Z",
|
|
"side": 0,
|
|
"message": "\u003e grub is 1 and location is /boot/grub/grub.cfg, if centos7 - 2 and /boot/grub2/grub.cfg, ubuntu - 2 and /boot/grub/grub.conf).\n\n\u003e But I\u0027m ok if you insist about just changing the order.\n\nif simple re-ordering will help, then let\u0027s just implement it.\n\ngeneral approach is to address the issues where they happened.\n\nif util layer is broken, let\u0027s fix it first.\n\nif utils can\u0027t be fixed easily and require any other help from the outer layers (such as manager/objects/drivers), then it\u0027s fine to spread the changes all over the layers.",
|
|
"parentUuid": "5a8bc5a2_77526768",
|
|
"range": {
|
|
"startLine": 30,
|
|
"startChar": 21,
|
|
"endLine": 30,
|
|
"endChar": 66
|
|
},
|
|
"revId": "8125d9ecd537825492669f5d52c68cd179143a0f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5a8bc5a2_08fd866d",
|
|
"filename": "fuel_agent/utils/grub.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 46,
|
|
"author": {
|
|
"id": 8003
|
|
},
|
|
"writtenOn": "2016-09-27T12:04:34Z",
|
|
"side": 0,
|
|
"message": "these paths should be re-ordered too.\n\nso, any path with *grub2* will be checked first.",
|
|
"range": {
|
|
"startLine": 45,
|
|
"startChar": 0,
|
|
"endLine": 46,
|
|
"endChar": 68
|
|
},
|
|
"revId": "8125d9ecd537825492669f5d52c68cd179143a0f",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |