From 201fd442349ffe9b94d008c6074bb048541a7c1f Mon Sep 17 00:00:00 2001
From: Igor Gajsin <igajsin@mirantis.com>
Date: Tue, 31 Mar 2015 11:19:23 +0300
Subject: [PATCH] Fix problem with deploy cinder-vmware role

The role cinder is "upstream" for the role cinder-vmware
which depend on it. Cinder was changed and cinder-vmware
should be changed after that.

Change-Id: I97c9d32d93fc3bb47a655be5a1cec69216b55f8f
Closes-bug: 1433201
---
 .../modular/openstack-cinder/openstack-cinder.pp          | 2 +-
 .../osnailyfacter/modular/openstack-cinder/tasks.yaml     | 2 +-
 deployment/puppet/osnailyfacter/modular/vmware/tasks.yaml | 2 +-
 deployment/puppet/vmware/manifests/cinder/vmdk.pp         | 8 --------
 4 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/deployment/puppet/osnailyfacter/modular/openstack-cinder/openstack-cinder.pp b/deployment/puppet/osnailyfacter/modular/openstack-cinder/openstack-cinder.pp
index 1aab0ea644..6301f23871 100644
--- a/deployment/puppet/osnailyfacter/modular/openstack-cinder/openstack-cinder.pp
+++ b/deployment/puppet/osnailyfacter/modular/openstack-cinder/openstack-cinder.pp
@@ -32,7 +32,7 @@ $amqp_hosts = inline_template("<%= @amqp_nodes.map {|x| x + ':' + @amqp_port}.jo
 # Determine who should get the volume service
 if (member($roles, 'cinder') and $storage_hash['volumes_lvm']) {
   $manage_volumes = 'iscsi'
-} elsif (member($roles, 'cinder') and $storage_hash['volumes_vmdk']) {
+} elsif member($roles, 'cinder-vmware') {
   $manage_volumes = 'vmdk'
 } elsif ($storage_hash['volumes_ceph']) {
   $manage_volumes = 'ceph'
diff --git a/deployment/puppet/osnailyfacter/modular/openstack-cinder/tasks.yaml b/deployment/puppet/osnailyfacter/modular/openstack-cinder/tasks.yaml
index 000322f1a3..e832bc187a 100644
--- a/deployment/puppet/osnailyfacter/modular/openstack-cinder/tasks.yaml
+++ b/deployment/puppet/osnailyfacter/modular/openstack-cinder/tasks.yaml
@@ -1,6 +1,6 @@
 - id: openstack-cinder
   type: puppet
-  groups: [primary-controller, controller]
+  groups: [primary-controller, controller, cinder-vmware]
   required_for: [deploy_end, openstack-controller]
   requires: [rabbitmq, keystone]
   parameters:
diff --git a/deployment/puppet/osnailyfacter/modular/vmware/tasks.yaml b/deployment/puppet/osnailyfacter/modular/vmware/tasks.yaml
index 9a546f95b6..5efbdea287 100644
--- a/deployment/puppet/osnailyfacter/modular/vmware/tasks.yaml
+++ b/deployment/puppet/osnailyfacter/modular/vmware/tasks.yaml
@@ -13,7 +13,7 @@
   type: puppet
   groups: [cinder-vmware]
   required_for: [deploy_end]
-  requires: [top-role-cinder]
+  requires: [top-role-cinder, openstack-cinder]
   condition: "settings:common.libvirt_type.value == 'vcenter' or settings:common.use_vcenter.value == true"
   parameters:
     puppet_manifest: /etc/puppet/modules/osnailyfacter/modular/vmware/cinder-vmware.pp
diff --git a/deployment/puppet/vmware/manifests/cinder/vmdk.pp b/deployment/puppet/vmware/manifests/cinder/vmdk.pp
index 53cb5ffcaf..876af16c28 100644
--- a/deployment/puppet/vmware/manifests/cinder/vmdk.pp
+++ b/deployment/puppet/vmware/manifests/cinder/vmdk.pp
@@ -115,14 +115,6 @@ define vmware::cinder::vmdk(
         }
       }
 
-      $upstart_link = "/etc/init.d/${cinder_volume_vmware}-${index}"
-      if ! defined(File[$upstart_link]) {
-        file { $upstart_link:
-          ensure => link,
-          target => '/etc/init.d/cinder-volume'
-        }
-      }
-
       $init_reload_cmd = '/sbin/initctl reload-configuration'
       $init_reload = 'initctl reload-configuration'
       if ! defined(Exec[$init_reload]) {