openstack/fuel-qa
Code Issues Proposed changes

Pylint: fix trivial issues 4

Browse Source 
Change-Id: I512c6faa3870b62a1516fd7aa5f5dd0979f745c7
fix: dangerous default values
Related-bug: #1556791
This commit is contained in:
Alexey Stepanov 2016-03-14 15:11:29 +03:00
parent 41d761bfdc
commit e7ae1fec8e
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fuelweb_test/helpers/utils.py
View File

@ -496,7 +496,9 @@ def get_network_template(template_name):
@logwrap @logwrap
def get_net_settings(remote, skip_interfaces=set()): def get_net_settings(remote, skip_interfaces=None):
if skip_interfaces is None:
skip_interfaces = set()
net_settings = dict() net_settings = dict()
interface_cmd = ('awk \'$1~/:/{split($1,iface,":"); print iface[1]}\'' interface_cmd = ('awk \'$1~/:/{split($1,iface,":"); print iface[1]}\''
' /proc/net/dev') ' /proc/net/dev')

4
fuelweb_test/tests/test_net_templates_base.py
View File

@ -83,7 +83,9 @@ class TestNetworkTemplatesBase(TestBasic):
@staticmethod @staticmethod
@logwrap @logwrap
def get_template_ep_for_role(template, role, nodegroup='default', def get_template_ep_for_role(template, role, nodegroup='default',
skip_net_roles=set()): skip_net_roles=None):
if skip_net_roles is None:
skip_net_roles = set()
tmpl = template['adv_net_template'][nodegroup] tmpl = template['adv_net_template'][nodegroup]
endpoints = set() endpoints = set()
networks = set() networks = set()