Update patch set 3
Patch Set 3: Code-Review-1 (7 comments) Patch-set: 3 Reviewer: Gerrit User 6677 <6677@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
adbd36d763
commit
75bccc5f97
|
@ -0,0 +1,159 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a8bc5a2_eccb8a51",
|
||||
"filename": "specs/10.0/astute_yaml_dissect.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 39,
|
||||
"author": {
|
||||
"id": 6677
|
||||
},
|
||||
"writtenOn": "2016-09-23T18:55:08Z",
|
||||
"side": 1,
|
||||
"message": "split",
|
||||
"range": {
|
||||
"startLine": 39,
|
||||
"startChar": 40,
|
||||
"endLine": 39,
|
||||
"endChar": 49
|
||||
},
|
||||
"revId": "ca90b433293074d59e001ff8464e21f3b5196ea9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a8bc5a2_ace8a2b5",
|
||||
"filename": "specs/10.0/astute_yaml_dissect.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 43,
|
||||
"author": {
|
||||
"id": 6677
|
||||
},
|
||||
"writtenOn": "2016-09-23T18:55:08Z",
|
||||
"side": 1,
|
||||
"message": "bigger",
|
||||
"range": {
|
||||
"startLine": 43,
|
||||
"startChar": 50,
|
||||
"endLine": 43,
|
||||
"endChar": 56
|
||||
},
|
||||
"revId": "ca90b433293074d59e001ff8464e21f3b5196ea9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a8bc5a2_0c519662",
|
||||
"filename": "specs/10.0/astute_yaml_dissect.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 47,
|
||||
"author": {
|
||||
"id": 6677
|
||||
},
|
||||
"writtenOn": "2016-09-23T18:55:08Z",
|
||||
"side": 1,
|
||||
"message": "Let\u0027s start with getting rid of globals.yaml first. I really like the ideas behind this specification, but the scope of the proposal is way too broad for a single feature. I\u0027d rather see it as a set of more granular changes.",
|
||||
"range": {
|
||||
"startLine": 47,
|
||||
"startChar": 0,
|
||||
"endLine": 47,
|
||||
"endChar": 70
|
||||
},
|
||||
"revId": "ca90b433293074d59e001ff8464e21f3b5196ea9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a8bc5a2_2c31f205",
|
||||
"filename": "specs/10.0/astute_yaml_dissect.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 53,
|
||||
"author": {
|
||||
"id": 6677
|
||||
},
|
||||
"writtenOn": "2016-09-23T18:55:08Z",
|
||||
"side": 1,
|
||||
"message": "You probably skipped the part where the metadata must be fetched from Nailgun API by Astute, instead of being propagated to it in every single RPC call as a one (huge) piece of text.",
|
||||
"revId": "ca90b433293074d59e001ff8464e21f3b5196ea9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a8bc5a2_4c463ec0",
|
||||
"filename": "specs/10.0/astute_yaml_dissect.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 139,
|
||||
"author": {
|
||||
"id": 6677
|
||||
},
|
||||
"writtenOn": "2016-09-23T18:55:08Z",
|
||||
"side": 1,
|
||||
"message": "It would be useful to describe and discuss the new structure you have in mind.",
|
||||
"range": {
|
||||
"startLine": 139,
|
||||
"startChar": 0,
|
||||
"endLine": 139,
|
||||
"endChar": 59
|
||||
},
|
||||
"revId": "ca90b433293074d59e001ff8464e21f3b5196ea9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a8bc5a2_4ce2bea0",
|
||||
"filename": "specs/10.0/astute_yaml_dissect.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 267,
|
||||
"author": {
|
||||
"id": 6677
|
||||
},
|
||||
"writtenOn": "2016-09-23T18:55:08Z",
|
||||
"side": 1,
|
||||
"message": "As you can see, every single item in this list is actually a full fledged feature that requires its own specification etc.",
|
||||
"range": {
|
||||
"startLine": 267,
|
||||
"startChar": 0,
|
||||
"endLine": 267,
|
||||
"endChar": 10
|
||||
},
|
||||
"revId": "ca90b433293074d59e001ff8464e21f3b5196ea9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a8bc5a2_6c969af1",
|
||||
"filename": "specs/10.0/astute_yaml_dissect.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 278,
|
||||
"author": {
|
||||
"id": 6677
|
||||
},
|
||||
"writtenOn": "2016-09-23T18:55:08Z",
|
||||
"side": 1,
|
||||
"message": "Some duplication or incorrect paste here.",
|
||||
"range": {
|
||||
"startLine": 276,
|
||||
"startChar": 0,
|
||||
"endLine": 278,
|
||||
"endChar": 48
|
||||
},
|
||||
"revId": "ca90b433293074d59e001ff8464e21f3b5196ea9",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue