openstack/fuel-specs
Code Issues Proposed changes

Update patch set 27

Browse Source 
Patch Set 27:

(1 comment)

Patch-set: 27
Reviewer: Gerrit User 12559 <12559@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 12559 2016-11-02 11:12:00 +00:00 committed by Gerrit Code Review
parent d6f0ee2339
commit 9db07c1776
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
3f8648848d4309c3b840ac33a8ca15bb7a34a4b6
View File

@ -46,6 +46,30 @@
"revId": "3f8648848d4309c3b840ac33a8ca15bb7a34a4b6", "revId": "3f8648848d4309c3b840ac33a8ca15bb7a34a4b6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false "unresolved": false
},
{
"key": {
"uuid": "ba5da102_ae2cec99",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 27
},
"lineNbr": 40,
"author": {
"id": 12559
},
"writtenOn": "2016-11-02T11:12:00Z",
"side": 1,
"message": "Igor, see my answers below.\n\n1. what should happen to assigned tags if original role (the one that brings tags to node) moved to another node?\n\nAll tags placed in role metadata(\u0027tags\u0027 field) will be unassigned from current node and assigned to another node. This is needed to support old role\u0027s based approach.\n\n2. what should happen if assigned role is changed and now has another list of tags?\n\nI think it\u0027s only validation issue. We can check that role is already assigned on some nodes and user should unassign this role before changing tags list belongs to this role.\n\n3.\n a) what should happen if user manually move one tag from host A to host C?\n\nExample: Role \u0027controller\u0027 produces tags: [\u0027mysql\u0027, \u0027neutron\u0027]; role \u0027compute\u0027 produces tags: [\u0027test\u0027].\nHost A - roles: [\u0027controller\u0027], tags: [\u0027mysql\u0027, \u0027neutron\u0027]. Host B - roles: [\u0027compute\u0027], tags: [\u0027test\u0027].\nUser want to move mysql tag from host A to host B. \u0027mysql\u0027 tag will be unassigned from host A and assigned on the host B.\nHost A - roles: [\u0027controller\u0027], tags: [\u0027neutron\u0027]. Host B - roles: [\u0027compute\u0027], tags: [\u0027test\u0027, \u0027mysql\u0027].\n\n b) and then move the original role (the one that brings this tag) from host A to host C?\n\nRole controller produces tags - [\u0027mysql\u0027, \u0027neutron\u0027], so, handler will try ti assign these tags to Host B, but, as we are using \u0027set\u0027 structure during the tags assignment then duplicated assignment is not expected as well.\nHost B - roles: [\u0027controller\u0027, \u0027compute\u0027], tags: [\u0027test\u0027, \u0027mysql\u0027, \u0027neutron\u0027].",
"parentUuid": "ba5da102_feb13502",
"range": {
"startLine": 39,
"startChar": 0,
"endLine": 40,
"endChar": 28
},
"revId": "3f8648848d4309c3b840ac33a8ca15bb7a34a4b6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
} }
] ]
} }