openstack/fuel-specs
Code Issues Proposed changes
9db07c1776
fuel-specs/435e71e68fa1a15f1dda26c5d0d93f7a57147c6a
Gerrit User 12559 3398ac1203 Update patch set 23 
Patch Set 23:

(1 comment)

Patch-set: 23
2016-08-18 15:49:45 +00:00

382 lines
11 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "3ac371cc_c9612a3b",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 23
},
"lineNbr": 43,
"author": {
"id": 18205
},
"writtenOn": "2016-08-17T16:17:16Z",
"side": 1,
"message": "what happens if user remove all tags from node? \nUI will show roles or only tags and what shows in UI if all tags are removed but role not.",
"range": {
"startLine": 43,
"startChar": 6,
"endLine": 43,
"endChar": 7
},
"revId": "435e71e68fa1a15f1dda26c5d0d93f7a57147c6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_07283f85",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 23
},
"lineNbr": 43,
"author": {
"id": 12559
},
"writtenOn": "2016-08-17T20:13:53Z",
"side": 1,
"message": "User will not be able to remove all tags from the node(API validator staff) like it\u0027s done for roles(node without roles can not belong to cluster).",
"parentUuid": "3ac371cc_c9612a3b",
"range": {
"startLine": 43,
"startChar": 6,
"endLine": 43,
"endChar": 7
},
"revId": "435e71e68fa1a15f1dda26c5d0d93f7a57147c6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_3c5c304a",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 23
},
"lineNbr": 43,
"author": {
"id": 12559
},
"writtenOn": "2016-08-18T15:40:16Z",
"side": 1,
"message": "Done",
"parentUuid": "3ac371cc_07283f85",
"range": {
"startLine": 43,
"startChar": 6,
"endLine": 43,
"endChar": 7
},
"revId": "435e71e68fa1a15f1dda26c5d0d93f7a57147c6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_09422268",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 23
},
"lineNbr": 66,
"author": {
"id": 18205
},
"writtenOn": "2016-08-17T16:17:16Z",
"side": 1,
"message": "What happens if user assigns only tag for the node.\nfor example tag \u0027rabbitmg\u0027 or it is not possible. the user should assign role controller in this case too.",
"range": {
"startLine": 66,
"startChar": 12,
"endLine": 66,
"endChar": 16
},
"revId": "435e71e68fa1a15f1dda26c5d0d93f7a57147c6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_395be5f7",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 23
},
"lineNbr": 66,
"author": {
"id": 12559
},
"writtenOn": "2016-08-17T20:13:53Z",
"side": 1,
"message": "We decided to use roles as interface for assignment groups of tags.\n\n\u003e What happens if user assigns only tag for the node.\n\nIt will not be possible to assign tag without role in initial implementation, but, we are planning to allow it in the future. So, user should assign at least \u0027virt\u0027 role and then he would be able to manipulate with tags.",
"parentUuid": "3ac371cc_09422268",
"range": {
"startLine": 66,
"startChar": 12,
"endLine": 66,
"endChar": 16
},
"revId": "435e71e68fa1a15f1dda26c5d0d93f7a57147c6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_9c572425",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 23
},
"lineNbr": 66,
"author": {
"id": 12559
},
"writtenOn": "2016-08-18T15:40:16Z",
"side": 1,
"message": "Done",
"parentUuid": "3ac371cc_395be5f7",
"range": {
"startLine": 66,
"startChar": 12,
"endLine": 66,
"endChar": 16
},
"revId": "435e71e68fa1a15f1dda26c5d0d93f7a57147c6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_aab13d49",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 23
},
"lineNbr": 85,
"author": {
"id": 8797
},
"writtenOn": "2016-08-17T16:27:29Z",
"side": 1,
"message": "when a role is assigned to node, the tags will automatically be extracted from the role metadata and assigned to the node",
"range": {
"startLine": 84,
"startChar": 2,
"endLine": 85,
"endChar": 23
},
"revId": "435e71e68fa1a15f1dda26c5d0d93f7a57147c6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_99749968",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 23
},
"lineNbr": 85,
"author": {
"id": 12559
},
"writtenOn": "2016-08-17T20:13:53Z",
"side": 1,
"message": "I meant that node\u0027s role should be copied to its tags during the role\u0027s assignment.",
"parentUuid": "3ac371cc_aab13d49",
"range": {
"startLine": 84,
"startChar": 2,
"endLine": 85,
"endChar": 23
},
"revId": "435e71e68fa1a15f1dda26c5d0d93f7a57147c6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_8f19a824",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 23
},
"lineNbr": 85,
"author": {
"id": 8797
},
"writtenOn": "2016-08-18T15:44:58Z",
"side": 1,
"message": "yes, that\u0027s said on L92-95. Both statements should be specified",
"parentUuid": "3ac371cc_99749968",
"range": {
"startLine": 84,
"startChar": 2,
"endLine": 85,
"endChar": 23
},
"revId": "435e71e68fa1a15f1dda26c5d0d93f7a57147c6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_0f11385d",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 23
},
"lineNbr": 85,
"author": {
"id": 12559
},
"writtenOn": "2016-08-18T15:49:45Z",
"side": 1,
"message": "Done",
"parentUuid": "3ac371cc_8f19a824",
"range": {
"startLine": 84,
"startChar": 2,
"endLine": 85,
"endChar": 23
},
"revId": "435e71e68fa1a15f1dda26c5d0d93f7a57147c6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_048167c3",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 23
},
"lineNbr": 197,
"author": {
"id": 18205
},
"writtenOn": "2016-08-17T16:17:16Z",
"side": 1,
"message": "I think it will be better to add separate model for tags.\nthe model shall contain following attributes:\nname,\nowner_id: release or cluster or plugin id.\nowner_class: release | cluster| plugin.\nread_only: boolean",
"range": {
"startLine": 197,
"startChar": 5,
"endLine": 197,
"endChar": 10
},
"revId": "435e71e68fa1a15f1dda26c5d0d93f7a57147c6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_fcac58a0",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 23
},
"lineNbr": 197,
"author": {
"id": 12559
},
"writtenOn": "2016-08-18T15:40:16Z",
"side": 1,
"message": "Done",
"parentUuid": "3ac371cc_048167c3",
"range": {
"startLine": 197,
"startChar": 5,
"endLine": 197,
"endChar": 10
},
"revId": "435e71e68fa1a15f1dda26c5d0d93f7a57147c6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_a4a173fa",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 23
},
"lineNbr": 228,
"author": {
"id": 18205
},
"writtenOn": "2016-08-17T16:17:16Z",
"side": 1,
"message": "column roles should be renamed to tags in deployment_graph_tasks table.",
"range": {
"startLine": 228,
"startChar": 0,
"endLine": 228,
"endChar": 72
},
"revId": "435e71e68fa1a15f1dda26c5d0d93f7a57147c6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_1cb3340b",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 23
},
"lineNbr": 228,
"author": {
"id": 12559
},
"writtenOn": "2016-08-18T15:40:16Z",
"side": 1,
"message": "Done",
"parentUuid": "3ac371cc_a4a173fa",
"range": {
"startLine": 228,
"startChar": 0,
"endLine": 228,
"endChar": 72
},
"revId": "435e71e68fa1a15f1dda26c5d0d93f7a57147c6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_a4c05351",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 23
},
"lineNbr": 324,
"author": {
"id": 18205
},
"writtenOn": "2016-08-17T16:17:16Z",
"side": 1,
"message": "not additional field. field roles should be renames to tags.\nthe version of library tasks shall be bumped.",
"range": {
"startLine": 324,
"startChar": 10,
"endLine": 324,
"endChar": 17
},
"revId": "435e71e68fa1a15f1dda26c5d0d93f7a57147c6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_dc06bc84",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 23
},
"lineNbr": 324,
"author": {
"id": 12559
},
"writtenOn": "2016-08-18T15:40:16Z",
"side": 1,
"message": "Done",
"parentUuid": "3ac371cc_a4c05351",
"range": {
"startLine": 324,
"startChar": 10,
"endLine": 324,
"endChar": 17
},
"revId": "435e71e68fa1a15f1dda26c5d0d93f7a57147c6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink