openstack
/
fuel-specs
Code Issues Proposed changes
fuel-specs/3847e770154af5ba870cdaae2b3...

333 lines
9.4 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "5a8bc5a2_f005b313",
"filename": "specs/10.0/astute_yaml_dissect.rst",
"patchSetId": 5
},
"lineNbr": 210,
"author": {
"id": 18205
},
"writtenOn": "2016-09-27T08:31:28Z",
"side": 1,
"message": "IMO: I think cluster data is extra. all content from cluster_data can be moved to root.\nAlso it would be better to add information about what kind of data it cluster specific and what is node specific.\ncluster specific data will be stored in cluster_data.yaml\nnode specific data will be stored in node_data.yaml",
"range": {
"startLine": 210,
"startChar": 6,
"endLine": 210,
"endChar": 18
},
"revId": "3847e770154af5ba870cdaae2b3d439e108e079e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_c97badbc",
"filename": "specs/10.0/astute_yaml_dissect.rst",
"patchSetId": 5
},
"lineNbr": 210,
"author": {
"id": 11827
},
"writtenOn": "2016-09-27T09:49:26Z",
"side": 1,
"message": "I think we can place openstack_data into cluster_data. In this case we\u0027ll have 2 big hashes, one of which will be serialized only once for cluster and second one which will be 2 times smaller will be serialized per node.",
"parentUuid": "5a8bc5a2_f005b313",
"range": {
"startLine": 210,
"startChar": 6,
"endLine": 210,
"endChar": 18
},
"revId": "3847e770154af5ba870cdaae2b3d439e108e079e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_50e3c7d8",
"filename": "specs/10.0/astute_yaml_dissect.rst",
"patchSetId": 5
},
"lineNbr": 502,
"author": {
"id": 18205
},
"writtenOn": "2016-09-27T08:31:28Z",
"side": 1,
"message": "what is different between kernel_params in deployment section and kernel_options in provision section?",
"range": {
"startLine": 502,
"startChar": 12,
"endLine": 502,
"endChar": 26
},
"revId": "3847e770154af5ba870cdaae2b3d439e108e079e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_6cb2a74d",
"filename": "specs/10.0/astute_yaml_dissect.rst",
"patchSetId": 5
},
"lineNbr": 502,
"author": {
"id": 11827
},
"writtenOn": "2016-09-27T09:49:26Z",
"side": 1,
"message": "Provision section places kernel option per node, such as udev rules and so on. Cluster kernel params store common kernel parameters.",
"parentUuid": "5a8bc5a2_50e3c7d8",
"range": {
"startLine": 502,
"startChar": 12,
"endLine": 502,
"endChar": 26
},
"revId": "3847e770154af5ba870cdaae2b3d439e108e079e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_10edbfb6",
"filename": "specs/10.0/astute_yaml_dissect.rst",
"patchSetId": 5
},
"lineNbr": 515,
"author": {
"id": 18205
},
"writtenOn": "2016-09-27T08:31:28Z",
"side": 1,
"message": "fuel_version has already met in deployment section.",
"range": {
"startLine": 515,
"startChar": 14,
"endLine": 515,
"endChar": 26
},
"revId": "3847e770154af5ba870cdaae2b3d439e108e079e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_2c7b3f7c",
"filename": "specs/10.0/astute_yaml_dissect.rst",
"patchSetId": 5
},
"lineNbr": 515,
"author": {
"id": 11827
},
"writtenOn": "2016-09-27T09:49:26Z",
"side": 1,
"message": "Done",
"parentUuid": "5a8bc5a2_10edbfb6",
"range": {
"startLine": 515,
"startChar": 14,
"endLine": 515,
"endChar": 26
},
"revId": "3847e770154af5ba870cdaae2b3d439e108e079e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_70344349",
"filename": "specs/10.0/astute_yaml_dissect.rst",
"patchSetId": 5
},
"lineNbr": 527,
"author": {
"id": 18205
},
"writtenOn": "2016-09-27T08:31:28Z",
"side": 1,
"message": "master_ip has already met in deployment section.",
"range": {
"startLine": 527,
"startChar": 14,
"endLine": 527,
"endChar": 23
},
"revId": "3847e770154af5ba870cdaae2b3d439e108e079e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_8c94538b",
"filename": "specs/10.0/astute_yaml_dissect.rst",
"patchSetId": 5
},
"lineNbr": 527,
"author": {
"id": 11827
},
"writtenOn": "2016-09-27T09:49:26Z",
"side": 1,
"message": "Done",
"parentUuid": "5a8bc5a2_70344349",
"range": {
"startLine": 527,
"startChar": 14,
"endLine": 527,
"endChar": 23
},
"revId": "3847e770154af5ba870cdaae2b3d439e108e079e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_b0708b0c",
"filename": "specs/10.0/astute_yaml_dissect.rst",
"patchSetId": 5
},
"lineNbr": 538,
"author": {
"id": 18205
},
"writtenOn": "2016-09-27T08:31:28Z",
"side": 1,
"message": "there is third place where is mentioned kernel_params :)",
"range": {
"startLine": 538,
"startChar": 16,
"endLine": 538,
"endChar": 29
},
"revId": "3847e770154af5ba870cdaae2b3d439e108e079e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_8cc29383",
"filename": "specs/10.0/astute_yaml_dissect.rst",
"patchSetId": 5
},
"lineNbr": 538,
"author": {
"id": 11827
},
"writtenOn": "2016-09-27T09:49:26Z",
"side": 1,
"message": "Done",
"parentUuid": "5a8bc5a2_b0708b0c",
"range": {
"startLine": 538,
"startChar": 16,
"endLine": 538,
"endChar": 29
},
"revId": "3847e770154af5ba870cdaae2b3d439e108e079e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_b005eb46",
"filename": "specs/10.0/astute_yaml_dissect.rst",
"patchSetId": 5
},
"lineNbr": 717,
"author": {
"id": 18205
},
"writtenOn": "2016-09-27T08:31:28Z",
"side": 1,
"message": "repo_setup has already met in deployment section.",
"range": {
"startLine": 717,
"startChar": 14,
"endLine": 717,
"endChar": 24
},
"revId": "3847e770154af5ba870cdaae2b3d439e108e079e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_ccebbbda",
"filename": "specs/10.0/astute_yaml_dissect.rst",
"patchSetId": 5
},
"lineNbr": 717,
"author": {
"id": 11827
},
"writtenOn": "2016-09-27T09:49:26Z",
"side": 1,
"message": "Deleted from here and saved in deployment section, as this one will be serialized per node and deployment - per cluster.",
"parentUuid": "5a8bc5a2_b005eb46",
"range": {
"startLine": 717,
"startChar": 14,
"endLine": 717,
"endChar": 24
},
"revId": "3847e770154af5ba870cdaae2b3d439e108e079e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_706c4308",
"filename": "specs/10.0/astute_yaml_dissect.rst",
"patchSetId": 5
},
"lineNbr": 909,
"author": {
"id": 18205
},
"writtenOn": "2016-09-27T08:31:28Z",
"side": 1,
"message": "IMO: it would be better to have section of nodes in root.",
"range": {
"startLine": 909,
"startChar": 10,
"endLine": 909,
"endChar": 15
},
"revId": "3847e770154af5ba870cdaae2b3d439e108e079e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a8bc5a2_6c42a7af",
"filename": "specs/10.0/astute_yaml_dissect.rst",
"patchSetId": 5
},
"lineNbr": 909,
"author": {
"id": 11827
},
"writtenOn": "2016-09-27T09:49:26Z",
"side": 1,
"message": "It has such section initially, but this small hash was only one we had there, so I move it into cluster section.",
"parentUuid": "5a8bc5a2_706c4308",
"range": {
"startLine": 909,
"startChar": 10,
"endLine": 909,
"endChar": 15
},
"revId": "3847e770154af5ba870cdaae2b3d439e108e079e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink