openstack/fuel-specs
Code Issues Proposed changes
f5d0099bb4
fuel-specs/6d8eef02cf23b479e0b3353645e150eef4237523
Gerrit User 12559 8396c022fc Update patch set 21 
Patch Set 21:

(1 comment)

Patch-set: 21
2016-08-18 15:45:20 +00:00

568 lines
20 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "3ac371cc_7b9bee72",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 20,
"author": {
"id": 18205
},
"writtenOn": "2016-08-16T11:15:42Z",
"side": 1,
"message": "We already have keywords \u0027roles\u0027 and \u0027groups\u0027 for defining some patterns to select nodes for task. This change introduces yet another one \u0027tags\u0027 and this means, that we will have 3 keywords for same action. I think need to extend existing roles instead of adding new think.",
"range": {
"startLine": 20,
"startChar": 13,
"endLine": 20,
"endChar": 24
},
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_cad04a56",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 20,
"author": {
"id": 12559
},
"writtenOn": "2016-08-16T12:32:53Z",
"side": 1,
"message": "\u0027group\u0027 is an entity for task\u0027s aggregation. Moreover, we are not using it directly in task\u0027s resolving process, it\u0027s something like intermediate link between role and task. In other words, we can not assign task\u0027s group to the node and we are resolving tasks using only node\u0027s role. So, we introduce only one extra entity for task\u0027s resolving.",
"parentUuid": "3ac371cc_7b9bee72",
"range": {
"startLine": 20,
"startChar": 13,
"endLine": 20,
"endChar": 24
},
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_6c6f6f2b",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 20,
"author": {
"id": 8797
},
"writtenOn": "2016-08-17T14:02:25Z",
"side": 1,
"message": "groups map multiple tasks in the task system. Tasks or task-groups can be associated with a role. When a role is used it describes a whole blob of things. For example controller is composed of tasks that set up nova, neutron, glance, horizon, keystone, database, amqp. In complex and/or large deployments, these components need to be able to be placed on different nodes. so we need a way to associate these with an element that is friendly to the user, and can be mapped to tasks similar to roles are now, this creates the need for tags.\n\ntags are a breakdown of the components that comprise a portable unit that may comprise a larger role. This allows for roles to be an abstraction, or simplification of assigning groups of tags to a node.\n\nAs far as the continued role of task-groups, this was discussed some revisions ago, it was agreed that we will not change task-groups at this time beyond the roleResolver being converted to tags",
"parentUuid": "3ac371cc_cad04a56",
"range": {
"startLine": 20,
"startChar": 13,
"endLine": 20,
"endChar": 24
},
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_1e9f5351",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 28,
"author": {
"id": 18205
},
"writtenOn": "2016-08-16T11:15:42Z",
"side": 1,
"message": "tags resolver",
"range": {
"startLine": 28,
"startChar": 20,
"endLine": 28,
"endChar": 24
},
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_3e7324e9",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 28,
"author": {
"id": 12559
},
"writtenOn": "2016-08-16T11:41:38Z",
"side": 1,
"message": "yes, this resolver is supposed to use tags instead roles, but, anyway, it\u0027s still task resolver.",
"parentUuid": "3ac371cc_1e9f5351",
"range": {
"startLine": 28,
"startChar": 20,
"endLine": 28,
"endChar": 24
},
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_2b0a01d3",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 34,
"author": {
"id": 19158
},
"writtenOn": "2016-08-15T12:52:39Z",
"side": 1,
"message": "What about tags filtering, tags editing, tags validation, handling reserved tags?",
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_02b7223a",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 34,
"author": {
"id": 12559
},
"writtenOn": "2016-08-15T14:12:50Z",
"side": 1,
"message": "I meant it, but skipped this part because this item has a \u0027nice to have\u0027 priority.",
"parentUuid": "3ac371cc_2b0a01d3",
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_28592eff",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 34,
"author": {
"id": 18205
},
"writtenOn": "2016-08-16T11:15:42Z",
"side": 1,
"message": "I think UI also should support for assigning/removing tags to/from node(s).",
"parentUuid": "3ac371cc_02b7223a",
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_1ee90881",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 34,
"author": {
"id": 12559
},
"writtenOn": "2016-08-16T11:41:38Z",
"side": 1,
"message": "I didn\u0027t mean that UI part will not be implemented at all. I meant that it has nice to have priority for this feature in the next release.",
"parentUuid": "3ac371cc_28592eff",
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_8bddf544",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 41,
"author": {
"id": 19158
},
"writtenOn": "2016-08-15T12:52:39Z",
"side": 1,
"message": "will be",
"range": {
"startLine": 41,
"startChar": 62,
"endLine": 41,
"endChar": 64
},
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_6b9eb957",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 45,
"author": {
"id": 19158
},
"writtenOn": "2016-08-15T12:52:39Z",
"side": 1,
"message": "This will be applied as template, what if node already have some tags that out of role? What if we have some tag from role assigned before role, then we adding role, removing role and this flag is over?\nWhat will be with node already having role when we are editing role tags?",
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_3da07ff4",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 45,
"author": {
"id": 12559
},
"writtenOn": "2016-08-15T14:12:50Z",
"side": 1,
"message": "I suppose such things should be resolved during patch\u0027s writing.\n\n1) what if node already have some tags that out of role?\nit\u0027s not possible to assign tags unless role is assigned.\n2) What if we have some tag from role assigned before role, then we adding role, removing role and this flag is over?\nRole is a service for tag\u0027s assignment, but, not for deletion. So, this flag will not be over.\n3) What will be with node already having role when we are editing role tags?\nDeletion of tags what are assigned to the nodes is forbidden.",
"parentUuid": "3ac371cc_6b9eb957",
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_1899fc1f",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 45,
"author": {
"id": 8797
},
"writtenOn": "2016-08-16T21:45:38Z",
"side": 1,
"message": "\u003e1) what if node already have some tags that out of role?\n\u003eit\u0027s not possible to assign tags unless role is assigned.\n\nIt should be possibly to assign tags w/o roles assigned. Assigning a role simply unpacks the tags tied to a role and applies them to the node. What happens, tasks are resolved by task and run on node, task resolver won\u0027t care about roles they are templates for tags.\n\n\u003e3) What will be with node already having role when we are editing role tags?\n\u003eDeletion of tags what are assigned to the nodes is forbidden.\n\nremoval of tags from nodes is allowed in nailgun, fuel-libraries release bundle may block this if it doesn\u0027t want to support it",
"parentUuid": "3ac371cc_3da07ff4",
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_4bb65ddd",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 62,
"author": {
"id": 19158
},
"writtenOn": "2016-08-15T12:52:39Z",
"side": 1,
"message": "unassignment behaviour is missing",
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_f169f68c",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 62,
"author": {
"id": 12559
},
"writtenOn": "2016-08-15T14:12:50Z",
"side": 1,
"message": "REST API section",
"parentUuid": "3ac371cc_4bb65ddd",
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_8be7b5e3",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 76,
"author": {
"id": 19158
},
"writtenOn": "2016-08-15T12:52:39Z",
"side": 1,
"message": "what does this numbers mean?",
"range": {
"startLine": 76,
"startChar": 21,
"endLine": 76,
"endChar": 22
},
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_11bf72fc",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 76,
"author": {
"id": 12559
},
"writtenOn": "2016-08-15T14:12:50Z",
"side": 1,
"message": "It just example of the tag\u0027s assignment what may be configured via extension.",
"parentUuid": "3ac371cc_8be7b5e3",
"range": {
"startLine": 76,
"startChar": 21,
"endLine": 76,
"endChar": 22
},
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7ac969e8_ec401f0a",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 141,
"author": {
"id": 8797
},
"writtenOn": "2016-08-16T21:45:38Z",
"side": 1,
"message": "is this to mean that \u0027corosoync\u0027 and \u0027corosync:1\u0027 are to be considered separate tags, and that the default tasks for \u0027corosync\u0027 will not match \u0027corosync:1\u0027? could it if i set the task some way like \u0027corosync:1\u0027 or \u0027corosync*\u0027?",
"range": {
"startLine": 140,
"startChar": 2,
"endLine": 141,
"endChar": 63
},
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_5cf18894",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 141,
"author": {
"id": 12559
},
"writtenOn": "2016-08-17T14:21:01Z",
"side": 1,
"message": "1) is this to mean that \u0027corosoync\u0027 and \u0027corosync:1\u0027 are to be considered separate tags, and that the default tasks for \u0027corosync\u0027 will not match \u0027corosync:1\u0027?\n\nyep, you\u0027re correct\n\n2) could it if i set the task some way like \u0027corosync:1\u0027 or \u0027corosync*\u0027?\n\nif you add tasks with tags \u0027corosync:1\u0027 or \u0027corosync*\u0027 what are completely matching with user-added tag then it will work.",
"parentUuid": "7ac969e8_ec401f0a",
"range": {
"startLine": 140,
"startChar": 2,
"endLine": 141,
"endChar": 63
},
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_f3433311",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 141,
"author": {
"id": 8797
},
"writtenOn": "2016-08-17T15:36:39Z",
"side": 1,
"message": "please add statement regarding 2 to spec. thanks",
"parentUuid": "3ac371cc_5cf18894",
"range": {
"startLine": 140,
"startChar": 2,
"endLine": 141,
"endChar": 63
},
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_af2bc480",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 141,
"author": {
"id": 12559
},
"writtenOn": "2016-08-18T15:45:20Z",
"side": 1,
"message": "Done",
"parentUuid": "3ac371cc_5cf18894",
"range": {
"startLine": 140,
"startChar": 2,
"endLine": 141,
"endChar": 63
},
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_4e4dcb71",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 145,
"author": {
"id": 19158
},
"writtenOn": "2016-08-15T12:52:39Z",
"side": 1,
"message": "Make a little bit more clear that node groups in tags is an just example of usage practice, not the something Nailgun or Astute should process a special way",
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_f748c65d",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 145,
"author": {
"id": 12559
},
"writtenOn": "2016-08-15T14:12:50Z",
"side": 1,
"message": "I described that these \u0027special tags\u0027 are not handled by Nailgun resolver and should be handled on puppet side separately.",
"parentUuid": "3ac371cc_4e4dcb71",
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_ae3effb5",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 161,
"author": {
"id": 19158
},
"writtenOn": "2016-08-15T12:52:39Z",
"side": 1,
"message": "space",
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_6e7367b2",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 182,
"author": {
"id": 19158
},
"writtenOn": "2016-08-15T12:52:39Z",
"side": 1,
"message": "Any reserved tags and their management?\n\nHow synthetic roles like controller-master will be tagged?",
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_b7ce4e58",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 182,
"author": {
"id": 12559
},
"writtenOn": "2016-08-15T14:12:50Z",
"side": 1,
"message": "Reserved tags will be placed in \u0027tags\u0027 field in \u0027roles_metadata\u0027 section. \nI don\u0027t understand reasons for separation of master node as we are not going to distribute its components among several nodes(at least now). So, answer is nohow.",
"parentUuid": "3ac371cc_6e7367b2",
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_4b2bfdeb",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 215,
"author": {
"id": 19158
},
"writtenOn": "2016-08-15T12:52:39Z",
"side": 1,
"message": "Any migration from data with already assigned roles but no tags?",
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3ac371cc_ce77fbd2",
"filename": "specs/10.0/role-decomposition.rst",
"patchSetId": 21
},
"lineNbr": 215,
"author": {
"id": 12559
},
"writtenOn": "2016-08-15T14:12:50Z",
"side": 1,
"message": "Described in Upgrade section",
"parentUuid": "3ac371cc_4b2bfdeb",
"revId": "6d8eef02cf23b479e0b3353645e150eef4237523",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink