openstack
/
fuel-ui
Code Issues Proposed changes

Force eqeqeq rule for plugin files 

Implements: blueprint converge-to-eslint-config-openstack

Change-Id: Ie4f16555c1fab9a3aa7b001e50434adc1c833f52
This commit is contained in:
Julia Aranovich 2016-01-26 15:24:42 +03:00
parent 730e0d10b7
commit c50eda1d60
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
static/plugins/vmware/vmware_models.js
View File

@ -49,7 +49,7 @@ var BaseModel = Backbone.Model
validate() {
var result = {};
_.each(this.attributes.metadata, (field) => {
if (!VmWareModels.isRegularField(field) || field.type == 'checkbox') {
if (!VmWareModels.isRegularField(field) || field.type === 'checkbox') {
return;
}
var isDisabled = this.checkRestrictions(restrictionModels, undefined, field);
@ -109,7 +109,7 @@ VmWareModels.NovaCompute = BaseModel.extend({
constructorName: 'NovaCompute',
checkEmptyTargetNode() {
var targetNode = this.get('target_node');
if (targetNode.current && targetNode.current.id == 'invalid') {
if (targetNode.current && targetNode.current.id === 'invalid') {
this.validationError = this.validationError || {};
this.validationError.target_node = i18n('vmware.invalid_target_node');
}
@ -130,7 +130,7 @@ VmWareModels.NovaCompute = BaseModel.extend({
var targetNode = this.get('target_node') || {};
if (targetNode.current) {
if (targetNode.current.id && targetNode.current.id != 'controllers' &&
if (targetNode.current.id && targetNode.current.id !== 'controllers' &&
keys.target_node && keys.target_node[targetNode.current.id]) {
this.validationError = this.validationError || {};
this.validationError.target_node = i18n('vmware.duplicate_value');

16
static/plugins/vmware/vmware_tab.js
View File

@ -41,14 +41,14 @@ var Field = React.createClass({
return (
<Input
{... _.pick(metadata, 'name', 'type', 'label', 'description')}
value={metadata.type == 'select' ? value.current.id : value}
value={metadata.type === 'select' ? value.current.id : value}
checked={value}
toggleable={metadata.type == 'password'}
toggleable={metadata.type === 'password'}
onChange={this.onChange}
disabled={this.props.disabled}
error={(this.props.model.validationError || {})[metadata.name]}
>
{metadata.type == 'select' && value.options.map((value) => {
{metadata.type === 'select' && value.options.map((value) => {
return <option key={value.id} value={value.id}>{value.label}</option>;
})}
</Input>
@ -107,7 +107,7 @@ var NovaCompute = React.createClass({
var nodes = this.props.cluster.get('nodes').filter((node) => node.hasRole('compute-vmware'));
targetNode.options = [];
if (targetNode.current.id == 'controllers' || !this.props.isLocked) {
if (targetNode.current.id === 'controllers' || !this.props.isLocked) {
targetNode.options.push({id: 'controllers', label: 'controllers'});
} else {
targetNode.options.push({id: 'invalid', label: 'Select node'});
@ -184,7 +184,7 @@ var AvailabilityZone = React.createClass({
},
renderComputes(actions) {
var novaComputes = this.props.model.get('nova_computes');
var isSingleInstance = novaComputes.length == 1;
var isSingleInstance = novaComputes.length === 1;
var disabled = actions.disable.nova_computes;
var cluster = this.props.cluster;
@ -361,18 +361,18 @@ var VmWareTab = React.createClass({
return false;
}
var oldData = JSON.stringify(old, (key, data) => {
if (key == 'target_node') {
if (key === 'target_node') {
delete data.options;
}
return data;
});
var currentData = JSON.stringify(current, (key, data) => {
if (key == 'target_node') {
if (key === 'target_node') {
delete data.options;
}
return data;
});
return oldData != currentData;
return oldData !== currentData;
},
isSavingPossible() {
return !this.state.model.validationError;