From 5b909a773a44e65beed81e32d7ca99920d1c51f9 Mon Sep 17 00:00:00 2001
From: Julia Aranovich <jkirnosova@mirantis.com>
Date: Wed, 25 Nov 2015 17:32:37 +0300
Subject: [PATCH] Fix node label validation

Closes-Bug: #1486952

Change-Id: I36b4a0adbc88aaac39db3529b458d924cf11d943
---
 .../nodes_tab_screens/node_list_screen.js     | 35 ++++++++++---------
 1 file changed, 19 insertions(+), 16 deletions(-)

diff --git a/nailgun/static/views/cluster_page_tabs/nodes_tab_screens/node_list_screen.js b/nailgun/static/views/cluster_page_tabs/nodes_tab_screens/node_list_screen.js
index 1efe2246cc..acae83847b 100644
--- a/nailgun/static/views/cluster_page_tabs/nodes_tab_screens/node_list_screen.js
+++ b/nailgun/static/views/cluster_page_tabs/nodes_tab_screens/node_list_screen.js
@@ -1345,7 +1345,7 @@ function($, _, i18n, Backbone, React, utils, models, dispatcher, controls, dialo
                 labelData = labels[index];
             labelData.key = newKey;
             if (!labelData.indeterminate) labelData.checked = true;
-            labelData.error = this.validateLabelKey(labelData, index);
+            this.validateLabels(labels);
             this.setState({labels: labels});
         },
         changeLabelState: function(index, key, checked) {
@@ -1353,7 +1353,7 @@ function($, _, i18n, Backbone, React, utils, models, dispatcher, controls, dialo
                 labelData = labels[index];
             labelData.checked = checked;
             labelData.indeterminate = false;
-            labelData.error = this.validateLabelKey(labelData, index);
+            this.validateLabels(labels);
             this.setState({labels: labels});
         },
         changeLabelValue: function(index, key, value) {
@@ -1361,23 +1361,26 @@ function($, _, i18n, Backbone, React, utils, models, dispatcher, controls, dialo
                 labelData = labels[index];
             labelData.values = [value || null];
             if (!labelData.indeterminate) labelData.checked = true;
-            labelData.error = this.validateLabelKey(labelData, index);
+            this.validateLabels(labels);
             this.setState({labels: labels});
         },
-        validateLabelKey: function(labelData, labelIndex) {
-            if (labelData.checked || labelData.indeterminate) {
-                var ns = 'cluster_page.nodes_tab.node_management_panel.labels.';
-                if (!_.trim(labelData.key)) {
-                    return i18n(ns + 'empty_label_key');
+        validateLabels: function(labels) {
+            _.each(labels, (currentLabel, currentIndex) => {
+                currentLabel.error = null;
+                if (currentLabel.checked || currentLabel.indeterminate) {
+                    var ns = 'cluster_page.nodes_tab.node_management_panel.labels.';
+                    if (!_.trim(currentLabel.key)) {
+                        currentLabel.error = i18n(ns + 'empty_label_key');
+                    } else {
+                        var doesLabelExist = _.any(labels, (label, index) => {
+                            return index != currentIndex &&
+                                _.trim(label.key) == _.trim(currentLabel.key) &&
+                                (label.checked || label.indeterminate);
+                        });
+                        if (doesLabelExist) currentLabel.error = i18n(ns + 'existing_label');
+                    }
                 }
-                if (_.any(this.state.labels, function(data, index) {
-                    if (index == labelIndex) return false;
-                    return _.trim(data.key) == _.trim(labelData.key) && (data.checked || data.indeterminate);
-                })) {
-                    return i18n(ns + 'existing_label');
-                }
-            }
-            return null;
+            });
         },
         isSavingPossible: function() {
             return !this.state.actionInProgress && this.hasChanges() && _.all(_.pluck(this.state.labels, 'error'), _.isNull);