Update patch set 4
Patch Set 4: Code-Review-1 (3 comments) Patch-set: 4
This commit is contained in:
parent
8ee3e0d384
commit
a5b1aca1aa
|
@ -0,0 +1,73 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "ba5da102_a5986c6b",
|
||||
"filename": "nailgun/nailgun/logger.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 99,
|
||||
"author": {
|
||||
"id": 8749
|
||||
},
|
||||
"writtenOn": "2016-11-02T22:46:11Z",
|
||||
"side": 1,
|
||||
"message": "I think we should use consistent naming, node_info is also can be referred to \"/api/nodes\" handler. My suggestion is to rename everything related attributes including file name to have prefix \"api_nodes_agent\" or something similar.",
|
||||
"range": {
|
||||
"startLine": 99,
|
||||
"startChar": 13,
|
||||
"endLine": 99,
|
||||
"endChar": 33
|
||||
},
|
||||
"revId": "53c6a7e8f4b4dd54fbec4e306dccda433bb1e54c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "ba5da102_a5dcec46",
|
||||
"filename": "nailgun/nailgun/logger.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 111,
|
||||
"author": {
|
||||
"id": 8749
|
||||
},
|
||||
"writtenOn": "2016-11-02T22:46:11Z",
|
||||
"side": 1,
|
||||
"message": "s/select/get/",
|
||||
"range": {
|
||||
"startLine": 111,
|
||||
"startChar": 10,
|
||||
"endLine": 111,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "53c6a7e8f4b4dd54fbec4e306dccda433bb1e54c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "ba5da102_45ecf0f2",
|
||||
"filename": "nailgun/nailgun/logger.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 113,
|
||||
"author": {
|
||||
"id": 8749
|
||||
},
|
||||
"writtenOn": "2016-11-02T22:46:11Z",
|
||||
"side": 1,
|
||||
"message": "It may include the version. E.g. /api/v1/nodes/agent, also are you sure, that \"/\" is mandatory?",
|
||||
"range": {
|
||||
"startLine": 113,
|
||||
"startChar": 38,
|
||||
"endLine": 113,
|
||||
"endChar": 39
|
||||
},
|
||||
"revId": "53c6a7e8f4b4dd54fbec4e306dccda433bb1e54c",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue