Update patch set 6
Patch Set 6: Code-Review-1 (1 comment) Patch-set: 6
This commit is contained in:
parent
8afb5836eb
commit
b8093a2e9e
|
@ -0,0 +1,27 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "ba5da102_81da5215",
|
||||
"filename": "nailgun/nailgun/logger.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 113,
|
||||
"author": {
|
||||
"id": 8749
|
||||
},
|
||||
"writtenOn": "2016-11-03T18:44:58Z",
|
||||
"side": 1,
|
||||
"message": "1. I don\u0027t think that somebody will remember about this code, when start adding new version. So match version by regexp.\n\n2. First url has \u0027/\u0027 at the end, second doesn\u0027t have it, use regexp to make sure that both options are possible.",
|
||||
"range": {
|
||||
"startLine": 113,
|
||||
"startChar": 61,
|
||||
"endLine": 113,
|
||||
"endChar": 63
|
||||
},
|
||||
"revId": "c016e344c6616340c83595c5d5272b69d648db06",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue