openstack
/
fuel-web
Code Issues Proposed changes
fuel-web/e1cab0e29a0fe123489495a61f9...

252 lines
9.4 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "5a3905b3_845ccf26",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 12,
"author": {
"id": 8392
},
"writtenOn": "2017-01-19T17:34:29Z",
"side": 1,
"message": "it was moved out from 9.2 (with comment) and returned back (w/o comments). looks strange.",
"revId": "e1cab0e29a0fe123489495a61f9aec0377147c09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a3905b3_24887b22",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 12,
"author": {
"id": 15140
},
"writtenOn": "2017-01-19T17:39:08Z",
"side": 1,
"message": "The original proposed fix was too complex, this is much simpler. I added it back because I thought we should try to push this simple fix into 9.2",
"parentUuid": "5a3905b3_845ccf26",
"revId": "e1cab0e29a0fe123489495a61f9aec0377147c09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a3905b3_89030873",
"filename": "nailgun/nailgun/test/integration/test_node_collection_handlers.py",
"patchSetId": 4
},
"lineNbr": 387,
"author": {
"id": 8392
},
"writtenOn": "2017-01-19T17:34:29Z",
"side": 1,
"message": "purpose of this test is not clear. also, it probably passes w/o code changes.",
"revId": "e1cab0e29a0fe123489495a61f9aec0377147c09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a3905b3_849e8f54",
"filename": "nailgun/nailgun/test/integration/test_node_collection_handlers.py",
"patchSetId": 4
},
"lineNbr": 387,
"author": {
"id": 15140
},
"writtenOn": "2017-01-19T17:39:08Z",
"side": 1,
"message": "It won\u0027t pass due to second node being found by interfaces, will return 409",
"parentUuid": "5a3905b3_89030873",
"revId": "e1cab0e29a0fe123489495a61f9aec0377147c09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a3905b3_85604837",
"filename": "nailgun/nailgun/test/integration/test_node_collection_handlers.py",
"patchSetId": 4
},
"lineNbr": 397,
"author": {
"id": 8392
},
"writtenOn": "2017-01-19T19:11:41Z",
"side": 1,
"message": "node is actually added via nailgun-agent (NodeAgentHandler). It\u0027s more appropriate to use this handler (to create both nodes). Also, node.mac will be set explicitly for both nodes in this case (which also makes test more clear).",
"revId": "e1cab0e29a0fe123489495a61f9aec0377147c09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a3905b3_9735d547",
"filename": "nailgun/nailgun/test/integration/test_node_collection_handlers.py",
"patchSetId": 4
},
"lineNbr": 397,
"author": {
"id": 15140
},
"writtenOn": "2017-01-19T23:24:35Z",
"side": 1,
"message": "NodeAgentHandler returns \"405 Method not allowed\" if I use \"post\". Throughout the tests I see that it is only used to update nodes, and NodeCollectionAgent is used to create nodes.\nI cannot create the first node via app because in this case node_nic_interfaces table is not populated and further logic fails. I don\u0027t know if that\u0027s a bug in test system or somethign else.",
"parentUuid": "5a3905b3_85604837",
"revId": "e1cab0e29a0fe123489495a61f9aec0377147c09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a3905b3_1277333b",
"filename": "nailgun/nailgun/test/integration/test_node_collection_handlers.py",
"patchSetId": 4
},
"lineNbr": 397,
"author": {
"id": 15140
},
"writtenOn": "2017-01-19T23:32:51Z",
"side": 1,
"message": "now I explicitly pass mac into create_node so it should be clearer.",
"parentUuid": "5a3905b3_85604837",
"revId": "e1cab0e29a0fe123489495a61f9aec0377147c09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a3905b3_1259f35a",
"filename": "nailgun/nailgun/test/integration/test_node_collection_handlers.py",
"patchSetId": 4
},
"lineNbr": 397,
"author": {
"id": 15140
},
"writtenOn": "2017-01-19T23:41:50Z",
"side": 1,
"message": "Replaced create_node with an app.post call, not sure why it did not work for me earlier, it\u0027s ok. Still cannot use NodeAgentHandler for this.",
"parentUuid": "5a3905b3_1277333b",
"revId": "e1cab0e29a0fe123489495a61f9aec0377147c09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a3905b3_129493e0",
"filename": "nailgun/nailgun/test/integration/test_node_collection_handlers.py",
"patchSetId": 4
},
"lineNbr": 397,
"author": {
"id": 15140
},
"writtenOn": "2017-01-19T23:41:50Z",
"side": 1,
"message": "Done",
"parentUuid": "5a3905b3_85604837",
"revId": "e1cab0e29a0fe123489495a61f9aec0377147c09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a3905b3_64fe036d",
"filename": "nailgun/nailgun/test/integration/test_node_collection_handlers.py",
"patchSetId": 4
},
"lineNbr": 402,
"author": {
"id": 8392
},
"writtenOn": "2017-01-19T17:40:56Z",
"side": 1,
"message": "what are node.mac on nodes? probably, MACs on all interfaces are not checked in this case.\n\nimo, node updates should be checked as well (with empty node.mac, seemingly)",
"revId": "e1cab0e29a0fe123489495a61f9aec0377147c09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a3905b3_a4b0eb8c",
"filename": "nailgun/nailgun/test/integration/test_node_collection_handlers.py",
"patchSetId": 4
},
"lineNbr": 402,
"author": {
"id": 15140
},
"writtenOn": "2017-01-19T17:45:12Z",
"side": 1,
"message": "when node is created, if node.mac is not found then all interfaces from meta are matched against interfaces in db https://github.com/openstack/fuel-web/blob/stable/mitaka/nailgun/nailgun/api/v1/validators/node.py#L130\nnode update uses the same search method - https://github.com/openstack/fuel-web/blob/stable/mitaka/nailgun/nailgun/api/v1/validators/node.py#L172",
"parentUuid": "5a3905b3_64fe036d",
"revId": "e1cab0e29a0fe123489495a61f9aec0377147c09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a3905b3_bf79d631",
"filename": "nailgun/nailgun/test/integration/test_node_collection_handlers.py",
"patchSetId": 4
},
"lineNbr": 402,
"author": {
"id": 15140
},
"writtenOn": "2017-01-19T17:57:21Z",
"side": 1,
"message": "\u003e what are node.mac on nodes?\nnode.mac are set as de:ad:be:ef:00:00 and de:ad:be:ef:00:01\nwhen second nodes is created, nailgun searches for de:ad:be:ef:00:01 in nodes table mac field, does not find it, and starts search with all macs in meta against node_nic_interfaces table through all macs there. This fix ensures that non-unique macs defined in settings are ignored in such search. This test relies on the fix to create two nodes with identical non-PXE macs",
"parentUuid": "5a3905b3_a4b0eb8c",
"revId": "e1cab0e29a0fe123489495a61f9aec0377147c09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a3905b3_852be8ea",
"filename": "nailgun/nailgun/test/integration/test_node_collection_handlers.py",
"patchSetId": 4
},
"lineNbr": 402,
"author": {
"id": 8392
},
"writtenOn": "2017-01-19T19:11:41Z",
"side": 1,
"message": "It would be better to have test that returns 409 in some case (i.e., when macs are not in NON_UNIQUE_MACS). \nIt will show difference more clearly.\n\nIMO, it would be helpful to have test for PUT as well (to not make API tests rely on knowledge of validator internals).",
"parentUuid": "5a3905b3_bf79d631",
"revId": "e1cab0e29a0fe123489495a61f9aec0377147c09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a3905b3_5760cd35",
"filename": "nailgun/nailgun/test/integration/test_node_collection_handlers.py",
"patchSetId": 4
},
"lineNbr": 402,
"author": {
"id": 15140
},
"writtenOn": "2017-01-19T23:24:35Z",
"side": 1,
"message": "Done, added a bunch of cases, post and put.",
"parentUuid": "5a3905b3_852be8ea",
"revId": "e1cab0e29a0fe123489495a61f9aec0377147c09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink