92 lines
3.5 KiB
Plaintext
92 lines
3.5 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "1aa78d24_c32b1f32",
|
|
"filename": "nailgun/nailgun/objects/serializers/deployment_graph.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 70,
|
|
"author": {
|
|
"id": 10391
|
|
},
|
|
"writtenOn": "2016-07-11T07:12:36Z",
|
|
"side": 1,
|
|
"message": "Shouldn\u0027t we send a deprecation letter to ML so one will be prepared that task_name will gone one day?",
|
|
"revId": "51a4a686b3d09f20bc24bb983aaaa9e473f9b121",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "1aa78d24_75bacfe2",
|
|
"filename": "nailgun/nailgun/objects/serializers/deployment_graph.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 70,
|
|
"author": {
|
|
"id": 19158
|
|
},
|
|
"writtenOn": "2016-07-11T12:32:58Z",
|
|
"side": 1,
|
|
"message": "we could consider it as undocumented alias, i\u0027ll clarify this",
|
|
"parentUuid": "1aa78d24_c32b1f32",
|
|
"revId": "51a4a686b3d09f20bc24bb983aaaa9e473f9b121",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "1aa78d24_43e72f12",
|
|
"filename": "nailgun/nailgun/objects/serializers/deployment_graph.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 77,
|
|
"author": {
|
|
"id": 10391
|
|
},
|
|
"writtenOn": "2016-07-11T07:12:36Z",
|
|
"side": 1,
|
|
"message": "Am I right that this filtering removes \"task_name\" completely? If so, are you sure no one relies on it?",
|
|
"revId": "51a4a686b3d09f20bc24bb983aaaa9e473f9b121",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "1aa78d24_d56d839a",
|
|
"filename": "nailgun/nailgun/objects/serializers/deployment_graph.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 77,
|
|
"author": {
|
|
"id": 19158
|
|
},
|
|
"writtenOn": "2016-07-11T12:32:58Z",
|
|
"side": 1,
|
|
"message": "That\u0027s right, this was a first question i\u0027ve asked, deployment guys (@vkuklin) convinced me that no one do.\nAlso this field is not reflected in specs.",
|
|
"parentUuid": "1aa78d24_43e72f12",
|
|
"revId": "51a4a686b3d09f20bc24bb983aaaa9e473f9b121",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "1aa78d24_8d82cffe",
|
|
"filename": "nailgun/nailgun/objects/serializers/deployment_graph.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 77,
|
|
"author": {
|
|
"id": 10391
|
|
},
|
|
"writtenOn": "2016-07-11T14:03:59Z",
|
|
"side": 1,
|
|
"message": "It doesn\u0027t matter whether it was reflected in the spec or not. We do have that field in already released version and that means someone may use it. Can you confirm that no one use it their automation script? I can\u0027t do that.\n\nI see that at least fuel system tests use it that field [1], and it\u0027s only our internal CI. What about external guys?\n\nMaybe I misunderstood something, and it won\u0027t affect end users. If so, please explain.\n\n[1]: https://github.com/openstack/fuel-qa/blob/586884c10a6ec03b6e3091e749d5712949a7b5cf/fuelweb_test/tests/tests_custom_graph/test_custom_graph.py#L209",
|
|
"parentUuid": "1aa78d24_d56d839a",
|
|
"revId": "51a4a686b3d09f20bc24bb983aaaa9e473f9b121",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |