c0c97c37b5
Patch Set 3: Code-Review+1 (1 comment) Patch-set: 3 Label: Code-Review=+1
57 lines
1.9 KiB
Plaintext
57 lines
1.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "1aa78d24_6bcb6273",
|
|
"filename": "nailgun/nailgun/objects/serializers/deployment_graph.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 43,
|
|
"author": {
|
|
"id": 21013
|
|
},
|
|
"writtenOn": "2016-07-04T06:38:38Z",
|
|
"side": 0,
|
|
"message": "This map causes the fields with \"old\" and \"new\" name appear in the result at the same time.\nWhat about to change the behaviour so that only \"new\" fields appear in the result? In this case we may just get rid of this hack.",
|
|
"revId": "80202eb7a8951d5dddae9ba3cf3d648d30abf7b8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "1aa78d24_1b6822f5",
|
|
"filename": "nailgun/nailgun/objects/serializers/deployment_graph.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 43,
|
|
"author": {
|
|
"id": 19158
|
|
},
|
|
"writtenOn": "2016-07-04T10:22:20Z",
|
|
"side": 0,
|
|
"message": "Yes. Old automation tools, clients e.t.c. could rely on old field names, so i cant\u0027 drop them at once, backward compatibility drop - is a major change.",
|
|
"parentUuid": "1aa78d24_6bcb6273",
|
|
"revId": "80202eb7a8951d5dddae9ba3cf3d648d30abf7b8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "1aa78d24_db55fa1d",
|
|
"filename": "nailgun/nailgun/objects/serializers/deployment_graph.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 43,
|
|
"author": {
|
|
"id": 21013
|
|
},
|
|
"writtenOn": "2016-07-04T10:23:42Z",
|
|
"side": 0,
|
|
"message": "ok",
|
|
"parentUuid": "1aa78d24_1b6822f5",
|
|
"revId": "80202eb7a8951d5dddae9ba3cf3d648d30abf7b8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |